From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD40C49EA3 for ; Mon, 28 Jun 2021 16:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEEDD60FEE for ; Mon, 28 Jun 2021 16:44:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231879AbhF1Qqy (ORCPT ); Mon, 28 Jun 2021 12:46:54 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56587 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231742AbhF1Qqu (ORCPT ); Mon, 28 Jun 2021 12:46:50 -0400 Received: from [192.168.1.155] ([77.9.21.236]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MCbMx-1m6x2M1VmF-009f0p; Mon, 28 Jun 2021 18:42:53 +0200 Subject: Re: [PATCH 09/14] d_path: introduce struct prepend_buffer To: Justin He , Al Viro , Linus Torvalds Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "Eric W . Biederman" , "Darrick J. Wong" , "Peter Zijlstra (Intel)" , Ira Weiny , Eric Biggers , "Ahmed S. Darwish" , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-s390 , linux-fsdevel , nd References: <20210519004901.3829541-1-viro@zeniv.linux.org.uk> <20210519004901.3829541-9-viro@zeniv.linux.org.uk> From: "Enrico Weigelt, metux IT consult" Message-ID: Date: Mon, 28 Jun 2021 18:42:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: tl Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:dthrUENFPhTDAJHaXxtOOW91ZJIlIa6ia2+y8lO4+z2hXozUBj6 DYlAEctl+dx18Zb5Drgx+eJKDYh2QJCaGKuRZZuo6b/S/CDBqhYbBHKEsVeIU8Wq1TxInTF rD0wPFlZ25k7mQUc/0Fo2K5+lktddQ50V0lD6frUWtFy7+Czqz6cVdO4xfZD047J1qvoI4z Vfe2uHxfJJsWZ4o5JTUPA== X-UI-Out-Filterresults: notjunk:1;V03:K0:4mFKrgfwtuQ=:rl6UFEQVjySGuqWqR0IjNV 4s2TFBnkMaQLnlsLBPq4dHlCuBX8PJ8aIXxoIxH5OTn6GFEC+W0mJFbZCdQ+NwpwqeSx5+xai Q+7wYY6QxQnj33ZsVIQDqsZzrYAopIaO+EOpegH9uU/YWQyZJWHBg2eVnqB3MMeccebe9T6Zu vVSWRsFmJS5mNWQs911NZCDOD+hpZtC9oan/ZDjMmthWnP5NAbH0fASCHQ86LHaSdRxPx4Rzi u3AciwqlX0eTg/6G0sdXi2GIoiAeMaM9CtlZ8XNro6vR4LM9GoAj0bToc7ahdpUtf5N1KoNKJ BjdZ4ZK8uhbdnqHv2J6wITmk6AXz6Mn0LRnEO7bRsE90LCWgxUN7TP/v3+hBv6kCHQF7T5Lmm /ytRccwOlUZRvqC6m1rsSbCkoNiC4aDbKC2nJKdWsofnDtfc9jdKbQCZvZLqzzc/W/XWCbIZR FaQYny11FmDqoJgH3sK+iL9C7ljkS9lSVP+3AGTfQFMJ6Bksf7T02z9xE1Wr6ZCUn2yCcdctL 7MBVLAHkIYPRNtUs8MA3RM= Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org >> this smells like a generic enough thing to go into lib, doesn't it ? >> > Maybe, but the struct prepend_buffer also needs to be moved into lib. > Is it necessary? Is there any other user of struct prepend_buffer? Don't have a specific use case right now, but it smells like a pretty generic string function. Is already having more than one user a hard requirement for putting something into lib ? --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287