From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-it0-f47.google.com ([209.85.214.47]:34971 "EHLO
        mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751465AbeFAPlQ (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 1 Jun 2018 11:41:16 -0400
Received: by mail-it0-f47.google.com with SMTP id a3-v6so2342745itd.0
        for <linux-fsdevel@vger.kernel.org>; Fri, 01 Jun 2018 08:41:16 -0700 (PDT)
Subject: Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to
 `ioprio_check_cap'
To: Adam Manzanares <Adam.Manzanares@wdc.com>,
        Christoph Hellwig <hch@lst.de>,
        Al Viro <viro@ZenIV.linux.org.uk>
Cc: kbuild test robot <lkp@intel.com>,
        "kbuild-all@01.org" <kbuild-all@01.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Jeff Moyer <jmoyer@redhat.com>
References: <201806010845.bDzP7QCW%fengguang.wu@intel.com>
 <20180601005448.GN30522@ZenIV.linux.org.uk> <20180601051353.GA21589@lst.de>
 <9ad99d87-07c3-6611-3252-49d788f8028e@wdc.com>
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <f24fe7e0-8531-bdca-4571-9a8caa4b4e70@kernel.dk>
Date: Fri, 1 Jun 2018 09:41:12 -0600
MIME-Version: 1.0
In-Reply-To: <9ad99d87-07c3-6611-3252-49d788f8028e@wdc.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 6/1/18 9:38 AM, Adam Manzanares wrote:
> On 5/31/18 10:13 PM, Christoph Hellwig wrote:
>>> +extern int ioprio_check_cap(int ioprio);
>>
>> Which then is implemented in block/ioprio.c, which depends on
>> CONFIG_BLOCK.  The code either needs a stub for !CONFIG_BLOCK
>> or moved elsewhere.
>
> My vote would be to move the ioprio code into fs/. At first glance I do 
> not see a dependence on the block layer in block/ioprio.c.
> 
> Any objections?

Since it's block ioprio code, I'd prefer a stub instead.

-- 
Jens Axboe