From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.etersoft.ru ([91.232.225.46]:53463 "EHLO mail.etersoft.ru"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932294AbdKONgq (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 15 Nov 2017 08:36:46 -0500
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Date: Wed, 15 Nov 2017 16:36:43 +0300
From: Vitaly Lipatov <lav@etersoft.ru>
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, bfields@fieldses.org,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fcntl: don't cap l_start and l_end values for F_GETLK64
 in compat syscall
In-Reply-To: <20171115131750.27717-1-jlayton@kernel.org>
References: <20171115131750.27717-1-jlayton@kernel.org>
Message-ID: <f3c22b98e9c5da1b873829d5271462c6@etersoft.ru>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Jeff Layton =D0=BF=D0=B8=D1=81=D0=B0=D0=BB 15.11.17 16:17:
> From: Jeff Layton <jlayton@redhat.com>
>=20
> Currently, we're capping the values too low in the F_GETLK64 case. The
> fields in that structure are 64-bit values, so we shouldn't need to any
> sort of fixup there.
>=20
> Make sure we check that assumption at build time in the future however
> by ensuring that the sizes we're copying will fit.
Nice fix.
The only question I do not know answer is what is purpose of=20
COMPAT_LOFF_T_MAX macro?

--=20
=D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC,
=D0=92=D0=B8=D1=82=D0=B0=D0=BB=D0=B8=D0=B9 =D0=9B=D0=B8=D0=BF=D0=B0=D1=82=
=D0=BE=D0=B2,
Etersoft