From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99713C433EC for ; Tue, 28 Jul 2020 23:55:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B6F720829 for ; Tue, 28 Jul 2020 23:55:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="nnq1/Ln3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730437AbgG1Xzc (ORCPT ); Tue, 28 Jul 2020 19:55:32 -0400 Received: from linux.microsoft.com ([13.77.154.182]:36258 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730005AbgG1Xzb (ORCPT ); Tue, 28 Jul 2020 19:55:31 -0400 Received: from [10.137.106.139] (unknown [131.107.174.11]) by linux.microsoft.com (Postfix) with ESMTPSA id 206D720B4908; Tue, 28 Jul 2020 16:55:31 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 206D720B4908 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1595980531; bh=w20ZeApysxkNgENHQge66diVoP/SQfne/ezQvvgUqcM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=nnq1/Ln3/IaJyZh6MpEpyRjnynpp3gggyXPT/zMkvX1w1syPnu2hKbPS6qxyDZnxS iKMgtnrSyFqUCEF9u5XDmKjPxBkR+ecBgizOPG2aHqejlOosEDxXCEWUMINrbBhQeK UE1cUIuE1lbhP1MNi/Lq5CeWTt4iiPMyWIVFTjTo= Subject: Re: [RFC PATCH v5 05/11] fs: add security blob and hooks for block_device To: Al Viro , Casey Schaufler Cc: agk@redhat.com, axboe@kernel.dk, snitzer@redhat.com, jmorris@namei.org, serge@hallyn.com, zohar@linux.ibm.com, paul@paul-moore.com, eparis@redhat.com, jannh@google.com, dm-devel@redhat.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-audit@redhat.com, tyhicks@linux.microsoft.com, linux-kernel@vger.kernel.org, corbet@lwn.net, sashal@kernel.org, jaskarankhurana@linux.microsoft.com, mdsakib@microsoft.com, nramas@linux.microsoft.com, pasha.tatashin@soleen.com References: <20200728213614.586312-1-deven.desai@linux.microsoft.com> <20200728213614.586312-6-deven.desai@linux.microsoft.com> <20200728224003.GC951209@ZenIV.linux.org.uk> From: Deven Bowers Message-ID: Date: Tue, 28 Jul 2020 16:55:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728224003.GC951209@ZenIV.linux.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 7/28/2020 3:40 PM, Al Viro wrote: > On Tue, Jul 28, 2020 at 03:22:59PM -0700, Casey Schaufler wrote: > >>> + hlist_for_each_entry(p, &security_hook_heads.bdev_setsecurity, list) { >>> + rc = p->hook.bdev_setsecurity(bdev, name, value, size); >>> + >>> + if (rc == -ENOSYS) >>> + rc = 0; >>> + >>> + if (rc != 0) >> >> Perhaps: >> else if (rc != 0) >> >>> + break; >>> + } >>> + >>> + return rc; > > hlist_for_each_entry(p, &security_hook_heads.bdev_setsecurity, list) { > rc = p->hook.bdev_setsecurity(bdev, name, value, size); > if (rc && rc != -ENOSYS) > return rc; > } > return 0; > > Easier to reason about that way... > Yeah, this is cleaner. I'll make the change for v6.