From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96871C4320D for ; Tue, 24 Sep 2019 20:05:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BE91214DA for ; Tue, 24 Sep 2019 20:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569355525; bh=nB3ANp+/569VNYtSayN5jMF7IHRxY+m3iP1QD1TGWw8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=D7BnQC7b4eq/DT0QY0h6t4adfsyWKiB9dOgLOSNu3n3FO72Sv3VDAFhX/31/u5ls7 AWWb/BiCTSfeS1qwzJZRE8fuugRCuzW1gS8RBRc3lbMZybIIO0LofNXCTR9N2phWoA 1jLQWdjQYQGmMdMZCMM6IhwQic+jHA5R7as/Bfbs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731789AbfIXUFW (ORCPT ); Tue, 24 Sep 2019 16:05:22 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:34122 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727602AbfIXUFV (ORCPT ); Tue, 24 Sep 2019 16:05:21 -0400 Received: by mail-io1-f66.google.com with SMTP id q1so7631195ion.1 for ; Tue, 24 Sep 2019 13:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tzqNMqA07jBcBpcqIcid0j0G7N4xLkFUhmGjg7IIOuU=; b=DCyKK193tOOwAbtGLptlJdOOKYY/0pAfa4quNNXrWUvG3TJ7wXw/pThGwGpG+9QiwN FazKM7SpbmIueD8YLUzNgzzgixAWUC4leRTPUG/z7IwX9zqjQydBTyOUnRi/xqLq7O0X vwnBLD/ePKlVhAXYcazuiJhoHAT+eKbgJPEi0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tzqNMqA07jBcBpcqIcid0j0G7N4xLkFUhmGjg7IIOuU=; b=C0mOi4Nkp1FQ0P/x1Wz9CppWSft87dnNLYtmgUMR8/LcHZ2BmY6tlbpIsWCfPjmZPm YMZiZPHkUo8lami8nNZiTN45oP6+jbSZ10zw+8JPl5pjimAEbki9hHgQ+YOcq9AreN99 XC1IJk9nYBJrdSctoyfmf3bWgvJvgShXcuQOcjFhX9mxzCPs4oj0Bj/r1OIIVTGSkKvp 8ONy4p4UOgx/+N6JKuEeb1bRo36fDRgDhb2tCrLIJqMki7xbAKJ67gmw5kJBNv8FyieQ QIlfImkJfKSnhkzdwM4vmy4WDSTNJ8iXJPMJ8cXLhVUrkmRdji/FFGCxM1N+Ap7lg67m W21w== X-Gm-Message-State: APjAAAU0C4n6W3UJzIZYWRft3pIgb8W3KZN2fhDCJL6lQJlE/JRslnvP l7/hgRak99hpjt5CoAGlRKniCQ== X-Google-Smtp-Source: APXvYqxALuZ+2sOPVcl1PCpmgHoIsSghK1bXD0k9qNItmHh8nea4aKSF+aMNcivHLWvltHMCZ47cgQ== X-Received: by 2002:a5d:89da:: with SMTP id a26mr4311422iot.61.1569355520865; Tue, 24 Sep 2019 13:05:20 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id k66sm4656319iof.25.2019.09.24.13.05.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Sep 2019 13:05:20 -0700 (PDT) Subject: Re: [PATCH] selftests: proc: Fix _GNU_SOURCE redefined build warns To: Alexey Dobriyan Cc: shuah@kernel.org, akpm@linux-foundation.org, sabyasachi.linux@gmail.com, jrdr.linux@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, "skh >> Shuah Khan" References: <20190924181910.23588-1-skhan@linuxfoundation.org> <20190924181910.23588-2-skhan@linuxfoundation.org> <20190924195253.GA2633@avx2> From: Shuah Khan Message-ID: Date: Tue, 24 Sep 2019 14:05:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190924195253.GA2633@avx2> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 9/24/19 1:52 PM, Alexey Dobriyan wrote: > On Tue, Sep 24, 2019 at 12:19:10PM -0600, Shuah Khan wrote: >> Fix the following _GNU_SOURCE redefined build warns: >> >> proc-loadavg-001.c:17: warning: "_GNU_SOURCE" redefined >> proc-self-syscall.c:16: warning: "_GNU_SOURCE" redefined >> proc-uptime-002.c:18: warning: "_GNU_SOURCE" redefined > >> +#ifndef _GNU_SOURCE >> #define _GNU_SOURCE >> +#endif > > Why are you doing this. > > There are 140 redefinitions of _GNU_SOURCE > Is there something wrong with getting rid of this warning? thanks, -- Shuah