From: Sander Eikelenboom <linux@eikelenboom.it>
To: Kirill Smelkov <kirr@nexedi.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
gluster-devel@gluster.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fuse: require /dev/fuse reads to have enough buffer capacity (take 2)
Date: Wed, 12 Jun 2019 18:28:17 +0200 [thread overview]
Message-ID: <f79ff13f-701b-89d8-149c-e53bb880bb77@eikelenboom.it> (raw)
In-Reply-To: <20190612141220.GA25389@deco.navytux.spb.ru>
On 12/06/2019 16:12, Kirill Smelkov wrote:
> On Wed, Jun 12, 2019 at 03:03:49PM +0200, Sander Eikelenboom wrote:
>> On 12/06/2019 13:25, Kirill Smelkov wrote:
>>> On Wed, Jun 12, 2019 at 09:44:49AM +0200, Miklos Szeredi wrote:
>>>> On Tue, Jun 11, 2019 at 10:28 PM Kirill Smelkov <kirr@nexedi.com> wrote:
>>>>
>>>>> Miklos, would 4K -> `sizeof(fuse_in_header) + sizeof(fuse_write_in)` for
>>>>> header room change be accepted?
>>>>
>>>> Yes, next cycle. For 4.2 I'll just push the revert.
>>>
>>> Thanks Miklos. Please consider queuing the following patch for 5.3.
>>> Sander, could you please confirm that glusterfs is not broken with this
>>> version of the check?
>>>
>>> Thanks beforehand,
>>> Kirill
>>
>>
>> Hmm unfortunately it doesn't build, see below.
>> [...]
>> fs/fuse/dev.c:1336:14: error: ‘fuse_in_header’ undeclared (first use in this function)
>> sizeof(fuse_in_header) + sizeof(fuse_write_in) + fc->max_write))
>
> Sorry, my bad, it was missing "struct" before fuse_in_header. I
> originally compile-tested the patch with `make -j4`, was distracted onto
> other topic and did not see the error after returning due to long tail
> of successful CC lines. Apologize for the inconvenience. Below is a
> fixed patch that was both compile-tested and runtime-tested with my FUSE
> workloads (non-glusterfs).
>
> Kirill
>
Just tested and it works for me, thanks !
--
Sander
next prev parent reply other threads:[~2019-06-12 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:46 Linux 5.2-RC regression bisected, mounting glusterfs volumes fails after commit: fuse: require /dev/fuse reads to have enough buffer capacity Sander Eikelenboom
2019-06-11 11:52 ` Miklos Szeredi
2019-06-11 20:27 ` Kirill Smelkov
2019-06-12 7:44 ` Miklos Szeredi
2019-06-12 11:25 ` [PATCH] fuse: require /dev/fuse reads to have enough buffer capacity (take 2) Kirill Smelkov
2019-06-12 12:11 ` Sander Eikelenboom
2019-06-12 13:03 ` Sander Eikelenboom
2019-06-12 14:12 ` Kirill Smelkov
2019-06-12 16:28 ` Sander Eikelenboom [this message]
2019-06-12 17:03 ` Kirill Smelkov
2019-06-23 7:26 ` [PATCH, RESEND] " Kirill Smelkov
2019-07-08 17:03 ` [PATCH, RESEND2] " Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79ff13f-701b-89d8-149c-e53bb880bb77@eikelenboom.it \
--to=linux@eikelenboom.it \
--cc=gluster-devel@gluster.org \
--cc=kirr@nexedi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).