From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73836C43381 for ; Tue, 12 Mar 2019 05:57:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 444BD2147C for ; Tue, 12 Mar 2019 05:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbfCLF5j (ORCPT ); Tue, 12 Mar 2019 01:57:39 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:37754 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725832AbfCLF5j (ORCPT ); Tue, 12 Mar 2019 01:57:39 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D1BD1586ABB5F7C54B4C; Tue, 12 Mar 2019 13:57:36 +0800 (CST) Received: from [127.0.0.1] (10.177.219.49) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.408.0; Tue, 12 Mar 2019 13:57:32 +0800 Subject: Re: [PATCH] fs/libfs.c: let lseek use SEEK_SET and SEEK_CUR From: yuyufen To: CC: References: <20190226093659.111125-1-yuyufen@huawei.com> Message-ID: Date: Tue, 12 Mar 2019 13:57:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190226093659.111125-1-yuyufen@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.177.219.49] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org ping ? On 2019/2/26 17:36, Yufen Yu wrote: > Let dcache_dir_lseek() use SEEK_SET and SEEK_CUR to make > code more unify. > > Signed-off-by: Yufen Yu > --- > fs/libfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/libfs.c b/fs/libfs.c > index 0fb590d79f30..37654d33bd29 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -144,9 +144,9 @@ loff_t dcache_dir_lseek(struct file *file, loff_t offset, int whence) > { > struct dentry *dentry = file->f_path.dentry; > switch (whence) { > - case 1: > + case SEEK_CUR: > offset += file->f_pos; > - case 0: > + case SEEK_SET: > if (offset >= 0) > break; > default: