From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45181 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751378AbdHIJvn (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 9 Aug 2017 05:51:43 -0400
Subject: Re: [PATCH 1/3] autofs - fix AT_NO_AUTOMOUNT not being honored
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        autofs mailing list <autofs@vger.kernel.org>,
        Ondrej Holy <oholy@redhat.com>,
        Colin Walters <walters@redhat.com>,
        Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
References: <150216641255.11652.4204561328197919771.stgit@pluto.themaw.net>
 <4689.1502267949@warthog.procyon.org.uk>
From: Ian Kent <raven@themaw.net>
Message-ID: <f7ea302d-2e17-b8bf-242e-fc06c4a0adcb@themaw.net>
Date: Wed, 9 Aug 2017 17:51:17 +0800
MIME-Version: 1.0
In-Reply-To: <4689.1502267949@warthog.procyon.org.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 09/08/17 16:39, David Howells wrote:
> Ian Kent <raven@themaw.net> wrote:
> 
>> In order to handle the AT_NO_AUTOMOUNT for both system calls the
>> negative dentry case in follow_automount() needs to be changed to
>> return ENOENT when the LOOKUP_AUTOMOUNT flag is clear (and the other
>> required flags are clear).
> 
> Should the be EREMOTE instead of ENOENT?

I thought about that and ended up thinking ENOENT was more sensible
but I'll look at it again.

Thanks
Ian