From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11274C7618B for ; Mon, 29 Jul 2019 14:57:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBD40216C8 for ; Mon, 29 Jul 2019 14:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564412251; bh=hMANmngripBsLJYd0Y/7x4OoPirri23tE2oLpVKpNB4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=p5XCon8QoEOYdHCVgYuEUVUTrKhKkAOPfiepPYygS7Lw+Y3itrwrdqO8M/PXBnycO sfee9QmeSXZxV8gVir38GDZHj45kk9+OgaGhj5w97PapkKxsjR6YkEgUo8XDrtTp3Q x8vDUSlHxD76IXNETGYKyXNMg9rQ7xWmkybDQUcs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387494AbfG2O52 (ORCPT ); Mon, 29 Jul 2019 10:57:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:56498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbfG2O51 (ORCPT ); Mon, 29 Jul 2019 10:57:27 -0400 Received: from [192.168.0.101] (unknown [180.111.32.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7F582067D; Mon, 29 Jul 2019 14:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564412246; bh=hMANmngripBsLJYd0Y/7x4OoPirri23tE2oLpVKpNB4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fmIYCh1tQ7HGhaBzdlRtL2bHHiOLDhp8u5eyZg8qMCO41oty4t2dCIDuN3sxkRk7e C/M4SoQ+feASKNhouXi6y5RnqTyepKX4N1mk3kln5zowMv36DnEMloxEU4IpopLkGr BVSnI82o391mNn0iFzF+OuKAodyIiVWC47INjDH8= Subject: Re: [f2fs-dev] [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups To: Chao Yu , Jaegeuk Kim Cc: Daniel Rosenberg , Jonathan Corbet , linux-f2fs-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com References: <20190723230529.251659-1-drosen@google.com> <20190723230529.251659-4-drosen@google.com> <9362e4ed-2be8-39f5-b4d9-9c86e37ab993@kernel.org> <20190729062735.GA98839@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Mon, 29 Jul 2019 22:57:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019-7-29 15:22, Chao Yu wrote: > On 2019/7/29 14:27, Jaegeuk Kim wrote: >> On 07/28, Chao Yu wrote: >>> On 2019-7-24 7:05, Daniel Rosenberg via Linux-f2fs-devel wrote: >>>> /* Flags that are appropriate for regular files (all but dir-specific ones). */ >>>> #define F2FS_REG_FLMASK (~(F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL)) >>> >>> We missed to add F2FS_CASEFOLD_FL here to exclude it in F2FS_REG_FLMASK. >> >> Applied. >> >>> >>>> @@ -1660,7 +1660,16 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) >>>> return -EPERM; >>>> >>>> oldflags = fi->i_flags; >>>> + if ((iflags ^ oldflags) & F2FS_CASEFOLD_FL) { >>>> + if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) >>>> + return -EOPNOTSUPP; >>>> + >>>> + if (!S_ISDIR(inode->i_mode)) >>>> + return -ENOTDIR; >>>> >>>> + if (!f2fs_empty_dir(inode)) >>>> + return -ENOTEMPTY; >>>> + } >> >> Modified like this: >> @@ -1665,6 +1665,13 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) >> if (IS_NOQUOTA(inode)) >> return -EPERM; >> >> + if ((iflags ^ fi->i_flags) & F2FS_CASEFOLD_FL) { >> + if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) >> + return -EOPNOTSUPP; >> + if (!f2fs_empty_dir(inode)) >> + return -ENOTEMPTY; >> + } >> + >> >> Note that, directory is checked by above change. >> >> I've uploaded in f2fs.git, so could you check it out and test a bit? > > I've checked it out, it looks good to me now, and later I will test this new > version. > > Reviewed-by: Chao Yu It can pass generic/556 as well. Thanks, > > Thanks, > >> >> Thanks, >> >>> >>> I applied the patches based on last Jaegeuk's dev branch, it seems we needs to >>> adjust above code a bit. Otherwise it looks good to me. >>> >>> BTW, it looks the patchset works fine with generic/556 testcase. >>> >>> Thanks, >> . >>