From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@fb.com>, Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bvanassche@acm.org>, Jan Kara <jack@suse.cz>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux FSDEVEL Mailinglist <linux-fsdevel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 1/3] block: bio: kill BIO_SEG_VALID flag
Date: Mon, 25 Mar 2019 09:02:03 +0100 [thread overview]
Message-ID: <ff3f6603-14d8-cc07-aea7-a077c5efbf9e@suse.de> (raw)
In-Reply-To: <20190322140135.GA17767@lst.de>
On 22/03/2019 15:01, Christoph Hellwig wrote:
>> + if (bio->bi_phys_segments == -1)
>> + bio->bi_phys_segments = 1;
>> + else
>> + bio->bi_phys_segments++;
>
> Minor nitpickm but I'd kust write this as:
>
> if (bio->bi_phys_segments == -1)
> bio->bi_phys_segments = 0;
> bio->bi_phys_segments++;
Yeah, that looks more obvious
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-03-25 8:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 13:13 [PATCH v2 0/3] add flag for tracking bio allocation Johannes Thumshirn
2019-03-22 13:13 ` [PATCH v2 1/3] block: bio: kill BIO_SEG_VALID flag Johannes Thumshirn
2019-03-22 14:01 ` Christoph Hellwig
2019-03-25 8:02 ` Johannes Thumshirn [this message]
2019-03-22 14:06 ` Hannes Reinecke
2019-03-22 22:00 ` Jens Axboe
2019-03-23 19:31 ` Jens Axboe
2019-03-25 13:32 ` Johannes Thumshirn
2019-03-22 22:40 ` Ming Lei
2019-03-22 13:13 ` [PATCH v2 2/3] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX Johannes Thumshirn
2019-03-22 14:01 ` Christoph Hellwig
2019-03-22 14:07 ` Hannes Reinecke
2019-03-22 13:13 ` [PATCH v2 3/3] block: bio: introduce BIO_ALLOCED flag and check it in bio_free Johannes Thumshirn
2019-03-22 14:02 ` Christoph Hellwig
2019-03-22 14:05 ` Hannes Reinecke
2019-03-22 21:30 ` Keith Busch
2019-03-22 23:04 ` Ming Lei
2019-03-22 14:10 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff3f6603-14d8-cc07-aea7-a077c5efbf9e@suse.de \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).