From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00AFDC43381 for ; Wed, 27 Feb 2019 12:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE3A52075B for ; Wed, 27 Feb 2019 12:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730039AbfB0Moj (ORCPT ); Wed, 27 Feb 2019 07:44:39 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:4178 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726062AbfB0Moj (ORCPT ); Wed, 27 Feb 2019 07:44:39 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 362FF2BFF29BAE86A670; Wed, 27 Feb 2019 20:44:37 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.408.0; Wed, 27 Feb 2019 20:44:28 +0800 Subject: Re: [PATCH] f2fs: no need to take page lock in readdir To: Gao Xiang , Jaegeuk Kim CC: , , References: <20190221045735.45419-1-gaoxiang25@huawei.com> From: Chao Yu Message-ID: Date: Wed, 27 Feb 2019 20:44:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190221045735.45419-1-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019/2/21 12:57, Gao Xiang wrote: > VFS will take inode_lock for readdir, therefore no need to > take page lock in readdir at all just as the majority of > other generic filesystems. > > This patch improves concurrency since .iterate_shared > was introduced to VFS years ago. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,