From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF270C433B4 for ; Wed, 21 Apr 2021 19:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78FB96145C for ; Wed, 21 Apr 2021 19:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239445AbhDUTFv (ORCPT ); Wed, 21 Apr 2021 15:05:51 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:33326 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234222AbhDUTFv (ORCPT ); Wed, 21 Apr 2021 15:05:51 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lZI9x-00D0JN-R2; Wed, 21 Apr 2021 13:05:13 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=fess.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lZI9v-00Arwg-E2; Wed, 21 Apr 2021 13:05:13 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Alexander Viro , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Morton , Kees Cook , Greg Ungerer , Mike Rapoport , Catalin Marinas , Kevin Brodsky , Michal Hocko , Feng Tang , Don Zickus , x86@kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20210421093453.6904-1-david@redhat.com> Date: Wed, 21 Apr 2021 14:03:49 -0500 In-Reply-To: <20210421093453.6904-1-david@redhat.com> (David Hildenbrand's message of "Wed, 21 Apr 2021 11:34:50 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1lZI9v-00Arwg-E2;;;mid=;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/oGtpTLgZT5xyLx7QaJ0kLkcjgE1O5huM= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v1 0/3] perf/binfmt/mm: remove in-tree usage of MAP_EXECUTABLE X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org David Hildenbrand writes: > Stumbling over the history of MAP_EXECUTABLE, I noticed that we still > have some in-tree users that we can get rid of. > > A good fit for the whole series could be Andrew's tree. In general this looks like a good cleanup. Acked-by: "Eric W. Biederman" As far as I can see we can go after MAP_DENYWRITE the same way. Today deny_write_access in open_exec is what causes -ETXTBSY when attempting to write to file that is current executing. Do you have any plans to look at that? Eric > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: Alexander Viro > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Andrew Morton > Cc: Kees Cook > Cc: "Eric W. Biederman" > Cc: Greg Ungerer > Cc: Mike Rapoport > Cc: Catalin Marinas > Cc: Kevin Brodsky > Cc: Michal Hocko > Cc: Feng Tang > Cc: Don Zickus > Cc: x86@kernel.org > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > > David Hildenbrand (3): > perf: MAP_EXECUTABLE does not indicate VM_MAYEXEC > binfmt: remove in-tree usage of MAP_EXECUTABLE > mm: ignore MAP_EXECUTABLE in ksys_mmap_pgoff() > > arch/x86/ia32/ia32_aout.c | 4 ++-- > fs/binfmt_aout.c | 4 ++-- > fs/binfmt_elf.c | 2 +- > fs/binfmt_elf_fdpic.c | 11 ++--------- > fs/binfmt_flat.c | 2 +- > include/linux/mman.h | 2 ++ > kernel/events/core.c | 2 -- > mm/mmap.c | 2 +- > mm/nommu.c | 2 +- > 9 files changed, 12 insertions(+), 19 deletions(-)