From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: [PATCH 0/26] sysfs cleanups v3. Date: Fri, 29 May 2009 13:18:35 -0700 Message-ID: References: <1242865694-2100-1-git-send-email-ebiederm@xmission.com> <20090528001418.GA2499@kroah.com> <20090528003721.GB2720@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Kay Sievers , Greg KH , Andrew Morton , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: Greg KH Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:45062 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753989AbZE2USo (ORCPT ); Fri, 29 May 2009 16:18:44 -0400 In-Reply-To: (Eric W. Biederman's message of "Thu\, 28 May 2009 15\:58\:25 -0700") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Here is the third respin of my sysfs patches. Tejun had a good point I was doing to much when I touched __sysfs_read_dir. So that work has been split into 3 patches. This made a good excuse for me to review the if (!dir_sd) check and be certain it was not needed. I have not found any actual problems so the resulting code is the same as the last patchset. Now the change to delete each dirent in sysfs_read_dir is it's own separate patch so Tejun can happily beat me up on just that one idea. I honestly can't see how holding sysfs_mutex over the entire directory deletion helps anything. The net change is less buggy than the current sysfs and a fair bit simpler. git-diff-tree --stat v2.6.30-rc5..HEAD drivers/base/core.c | 21 +-- fs/namei.c | 22 -- fs/sysfs/dir.c | 596 ++++++++++++++++--------------------------------- fs/sysfs/file.c | 47 +--- fs/sysfs/inode.c | 154 ++++++++------ fs/sysfs/mount.c | 20 +- fs/sysfs/symlink.c | 93 +++++---- fs/sysfs/sysfs.h | 28 +-- include/linux/namei.h | 1 - include/linux/sysfs.h | 9 + 10 files changed, 383 insertions(+), 608 deletions(-) Eric