From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 20/20] sysfs: Normalize error handling in sysfs_fill_inode Date: Thu, 21 May 2009 03:29:57 -0700 Message-ID: References: <1242865694-2100-5-git-send-email-ebiederm@xmission.com> <1242865694-2100-6-git-send-email-ebiederm@xmission.com> <1242865694-2100-7-git-send-email-ebiederm@xmission.com> <1242865694-2100-8-git-send-email-ebiederm@xmission.com> <1242865694-2100-9-git-send-email-ebiederm@xmission.com> <1242865694-2100-10-git-send-email-ebiederm@xmission.com> <1242865694-2100-11-git-send-email-ebiederm@xmission.com> <1242865694-2100-12-git-send-email-ebiederm@xmission.com> <1242865694-2100-13-git-send-email-ebiederm@xmission.com> <1242865694-2100-14-git-send-email-ebiederm@xmission.com> <1242865694-2100-15-git-send-email-ebiederm@xmission.com> <1242865694-2100-16-git-send-email-ebiederm@xmission.com> <1242865694-2100-17-git-send-email-ebiederm@xmission.com> <1242865694-2100-18-git-send-email-ebiederm@xmission.com> <1242865694-2100-19-git-send-email-ebiederm@xmission.com> <1242865694-2100-20-git-send-email-ebiederm@xmission.com> <4A152255.9060703@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: Tejun Heo Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:48556 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbZEUKaA (ORCPT ); Thu, 21 May 2009 06:30:00 -0400 In-Reply-To: <4A152255.9060703@kernel.org> (Tejun Heo's message of "Thu\, 21 May 2009 18\:43\:49 +0900") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Tejun Heo writes: > Eric W. Biederman wrote: >> From: Eric W. Biederman >> >> Use a single error exit path instead of doing whatever >> is the required cleanup at each point we find the error. >> Ultimately this should make the code more maintainable. >> >> Signed-off-by: Eric W. Biederman > > For 0018-0020, > > Acked-by: Tejun Heo Thanks for taking the time to review these patches. Eric