linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] 22.t: fix check for POLLIN
Date: Wed, 23 May 2018 12:19:02 -0400	[thread overview]
Message-ID: <x49fu2iqr9l.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20180523161407.30689-2-hch@lst.de> (Christoph Hellwig's message of "Wed, 23 May 2018 18:14:07 +0200")

Christoph Hellwig <hch@lst.de> writes:

> Recent kernels seem to also set POLLRDNORM in addition to POLLIN,
> so check by masking instead of equality.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, Christoph, I'll pull this in.

-Jeff

> ---
>  harness/cases/22.t | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/harness/cases/22.t b/harness/cases/22.t
> index c7e7c0e..f376afc 100644
> --- a/harness/cases/22.t
> +++ b/harness/cases/22.t
> @@ -139,7 +139,7 @@ int test_main(void)
>  			printf("parent: io_pgetevents reports wrong fd\n");
>  			return 1;
>  		}
> -		if (ev.res != POLLIN) {
> +		if (!(ev.res & POLLIN)) {
>  			printf("parent: io_pgetevents did not report readable fd\n");
>  			return 1;
>  		}

      reply	other threads:[~2018-05-23 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 16:14 libaio: fix aio poll test Christoph Hellwig
2018-05-23 16:14 ` [PATCH] 22.t: fix check for POLLIN Christoph Hellwig
2018-05-23 16:19   ` Jeff Moyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49fu2iqr9l.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --subject='Re: [PATCH] 22.t: fix check for POLLIN' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).