linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: adam.manzanares@wdc.com
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	axboe@kernel.dk, bcrl@kvack.org, tglx@linutronix.de,
	mingo@kernel.org, pombredanne@nexb.com,
	kstewart@linuxfoundation.org, gregkh@linuxfoundation.org,
	bigeasy@linutronix.de, jack@suse.cz, darrick.wong@oracle.com,
	rgoldwyn@suse.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-aio@kvack.org,
	linux-api@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH v5 4/5] fs: blkdev set bio prio from kiocb prio
Date: Mon, 21 May 2018 17:04:17 -0400	[thread overview]
Message-ID: <x49r2m4u3e6.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20180521160147.2372-5-adam.manzanares@wdc.com> (adam manzanares's message of "Mon, 21 May 2018 09:01:46 -0700")

adam.manzanares@wdc.com writes:

> From: Adam Manzanares <adam.manzanares@wdc.com>
>
> Now that kiocb has an ioprio field copy this over to the bio when it is
> created from the kiocb.
>
> Signed-off-by: Adam Manzanares <adam.manzanares@wdc.com>
> ---
>  fs/block_dev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 7ec920e27065..da1e94d2bb75 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -355,6 +355,7 @@ __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter, int nr_pages)
>  		bio->bi_write_hint = iocb->ki_hint;
>  		bio->bi_private = dio;
>  		bio->bi_end_io = blkdev_bio_end_io;
> +		bio->bi_ioprio = iocb->ki_ioprio;
>  
>  		ret = bio_iov_iter_get_pages(bio, iter);
>  		if (unlikely(ret)) {

Forgot to mention, you should also convert __blkdev_direct_IO_simple.

-Jeff

  parent reply	other threads:[~2018-05-21 21:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 16:01 [PATCH v5 0/5] AIO add per-command iopriority adam.manzanares
2018-05-21 16:01 ` [PATCH v5 1/5] block: add ioprio_check_cap function adam.manzanares
2018-05-21 20:58   ` Jeff Moyer
2018-05-21 16:01 ` [PATCH v5 2/5] fs: Convert kiocb rw_hint from enum to u16 adam.manzanares
2018-05-22 10:04   ` Christoph Hellwig
2018-05-21 16:01 ` [PATCH v5 3/5] fs: Add aio iopriority support adam.manzanares
2018-05-21 20:58   ` Jeff Moyer
2018-05-22 10:05   ` Christoph Hellwig
2018-05-22 17:43   ` kbuild test robot
2018-05-21 16:01 ` [PATCH v5 4/5] fs: blkdev set bio prio from kiocb prio adam.manzanares
2018-05-21 20:59   ` Jeff Moyer
2018-05-21 21:04   ` Jeff Moyer [this message]
2018-05-21 21:43     ` Adam Manzanares
2018-05-21 16:01 ` [PATCH v5 5/5] fs: iomap dio " adam.manzanares
2018-05-21 20:59   ` Jeff Moyer
2018-05-22 10:05   ` Christoph Hellwig
2018-05-21 20:57 ` [PATCH v5 0/5] AIO add per-command iopriority Jeff Moyer
2018-05-21 21:42   ` Adam Manzanares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49r2m4u3e6.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=adam.manzanares@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=bcrl@kvack.org \
    --cc=bigeasy@linutronix.de \
    --cc=darrick.wong@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=rgoldwyn@suse.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).