From: Jeff Moyer <jmoyer@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: dan.j.williams@intel.com, linux-fsdevel@vger.kernel.org,
linux-nvdimm@lists.01.org, willy@infradead.org
Subject: Re: [patch] dax: pass NOWAIT flag to iomap_apply
Date: Thu, 06 Feb 2020 09:33:39 -0500 [thread overview]
Message-ID: <x49tv43lr98.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20200206084740.GE14001@quack2.suse.cz> (Jan Kara's message of "Thu, 6 Feb 2020 09:47:40 +0100")
Jan Kara <jack@suse.cz> writes:
> On Wed 05-02-20 14:15:58, Jeff Moyer wrote:
>> fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o
>> dax". The reason is that the initial pwrite to an empty file with the
>> RWF_NOWAIT flag set does not return -EAGAIN. It turns out that
>> dax_iomap_rw doesn't pass that flag through to iomap_apply.
>>
>> With this patch applied, generic/471 passes for me.
>>
>> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
>
> The patch looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> BTW, I've just noticed ext4 seems to be buggy in this regard and even this
> patch doesn't fix it. So I guess you've been using XFS for testing this?
That's right, sorry I didn't mention that. Will you send a patch for
ext4, or do you want me to look into it?
Thanks!
Jeff
next prev parent reply other threads:[~2020-02-06 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 19:15 [patch] dax: pass NOWAIT flag to iomap_apply Jeff Moyer
2020-02-05 19:28 ` Christoph Hellwig
2020-02-06 4:52 ` Dan Williams
2020-02-06 8:47 ` Jan Kara
2020-02-06 14:33 ` Jeff Moyer [this message]
2020-02-06 14:43 ` Jan Kara
2020-02-06 15:39 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49tv43lr98.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).