From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "arnd@arndb.de" <arnd@arndb.de>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>
Cc: "scott.branden@broadcom.com" <scott.branden@broadcom.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"yoshihiro.shimoda.uh@renesas.com"
<yoshihiro.shimoda.uh@renesas.com>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"rjui@broadcom.com" <rjui@broadcom.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] gpio: xgs-iproc: remove __exit annotation for iproc_gpio_remove
Date: Tue, 10 Dec 2019 20:24:33 +0000 [thread overview]
Message-ID: <01669f6c5d0e40c7a410da2dcce6c9e825e4a1d4.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <20191210195414.705239-1-arnd@arndb.de>
On Tue, 2019-12-10 at 20:54 +0100, Arnd Bergmann wrote:
> When built into the kernel, the driver causes a link problem:
>
> `iproc_gpio_remove' referenced in section `.data' of drivers/gpio/gpio-xgs-iproc.o: defined in discarded section `.exit.text' of drivers/gpio/gpio-xgs-iproc.o
>
> Remove the incorrect annotation.
>
> Fixes: 6a41b6c5fc20 ("gpio: Add xgs-iproc driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
What's the current best practice w.r.t.__init and __exit? I seem to
have messed this up on multiple fronts.
> ---
> drivers/gpio/gpio-xgs-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
> index 773e5c24309e..b21c2e436b61 100644
> --- a/drivers/gpio/gpio-xgs-iproc.c
> +++ b/drivers/gpio/gpio-xgs-iproc.c
> @@ -280,7 +280,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int __exit iproc_gpio_remove(struct platform_device *pdev)
> +static int iproc_gpio_remove(struct platform_device *pdev)
> {
> struct iproc_gpio_chip *chip;
>
next prev parent reply other threads:[~2019-12-10 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 19:54 [PATCH] gpio: xgs-iproc: remove __exit annotation for iproc_gpio_remove Arnd Bergmann
2019-12-10 20:24 ` Chris Packham [this message]
2019-12-10 20:28 ` Arnd Bergmann
2019-12-11 9:14 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01669f6c5d0e40c7a410da2dcce6c9e825e4a1d4.camel@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).