From: Philipp Zabel <p.zabel@pengutronix.de>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
aisheng.dong@nxp.com, festevam@gmail.com, shawnguo@kernel.org,
stefan@agner.ch, kernel@pengutronix.de, linus.walleij@linaro.org,
s.hauer@pengutronix.de, linux-imx@nxp.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: freescale: imx: Add of_node_put() before return
Date: Thu, 08 Aug 2019 16:56:28 +0200 [thread overview]
Message-ID: <1565276188.3656.24.camel@pengutronix.de> (raw)
In-Reply-To: <20190808074720.15754-1-nishkadg.linux@gmail.com>
On Thu, 2019-08-08 at 13:17 +0530, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node() puts the previous node;
> however, in the case of a return from the middle of the loop, there is no
> put, thus causing a memory leak. Hence put of_node_put() statements as
> required before two mid-loop return statements.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/pinctrl/freescale/pinctrl-imx.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 83ff9532bae6..9f42036c5fbb 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -672,8 +672,10 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
>
> grp = devm_kzalloc(ipctl->dev, sizeof(struct group_desc),
> GFP_KERNEL);
This looks to me like it could just allocate an array of struct
group_desc upfront, just like the group_names array. Same for the
functions in imx_pinctrl_probe_dt(). Not an issue with this patch
though.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
> - if (!grp)
> + if (!grp) {
> + of_node_put(child);
> return -ENOMEM;
> + }
>
> mutex_lock(&ipctl->mutex);
> radix_tree_insert(&pctl->pin_group_tree,
> @@ -697,12 +699,17 @@ static bool imx_pinctrl_dt_is_flat_functions(struct device_node *np)
> struct device_node *pinctrl_np;
>
> for_each_child_of_node(np, function_np) {
> - if (of_property_read_bool(function_np, "fsl,pins"))
> + if (of_property_read_bool(function_np, "fsl,pins")) {
> + of_node_put(function_np);
> return true;
> + }
>
> for_each_child_of_node(function_np, pinctrl_np) {
> - if (of_property_read_bool(pinctrl_np, "fsl,pins"))
> + if (of_property_read_bool(pinctrl_np, "fsl,pins")) {
> + of_node_put(pinctrl_np);
> + of_node_put(function_np);
> return false;
> + }
> }
> }
>
next prev parent reply other threads:[~2019-08-08 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:47 [PATCH] pinctrl: freescale: imx: Add of_node_put() before return Nishka Dasgupta
2019-08-08 14:56 ` Philipp Zabel [this message]
2019-08-10 8:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565276188.3656.24.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=nishkadg.linux@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).