From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Ray Jui <rjui@broadcom.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>,
Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: [PATCH 2/3] gpio: pxa: Fix return value of pxa_gpio_probe()
Date: Fri, 22 May 2020 12:12:19 +0800 [thread overview]
Message-ID: <1590120740-22912-2-git-send-email-yangtiezhu@loongson.cn> (raw)
In-Reply-To: <1590120740-22912-1-git-send-email-yangtiezhu@loongson.cn>
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.
Fixes: 542c25b7a209 ("drivers: gpio: pxa: use devm_platform_ioremap_resource()")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/gpio/gpio-pxa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 1361270..0cb6600 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -660,8 +660,8 @@ static int pxa_gpio_probe(struct platform_device *pdev)
pchip->irq1 = irq1;
gpio_reg_base = devm_platform_ioremap_resource(pdev, 0);
- if (!gpio_reg_base)
- return -EINVAL;
+ if (IS_ERR(gpio_reg_base))
+ return PTR_ERR(gpio_reg_base);
clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(clk)) {
--
2.1.0
next prev parent reply other threads:[~2020-05-22 4:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 4:12 [PATCH 1/3] gpio: bcm-kona: Fix return value of bcm_kona_gpio_probe() Tiezhu Yang
2020-05-22 4:12 ` Tiezhu Yang [this message]
2020-05-22 19:07 ` [PATCH 2/3] gpio: pxa: Fix return value of pxa_gpio_probe() Robert Jarzmik
2020-05-23 3:24 ` Tiezhu Yang
2020-05-25 9:14 ` Bartosz Golaszewski
2020-05-27 18:26 ` Robert Jarzmik
2020-05-22 4:12 ` [PATCH 3/3] gpio: pxa: Add COMPILE_TEST support Tiezhu Yang
2020-05-25 9:15 ` Bartosz Golaszewski
2020-05-25 9:16 ` [PATCH 1/3] gpio: bcm-kona: Fix return value of bcm_kona_gpio_probe() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590120740-22912-2-git-send-email-yangtiezhu@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).