From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A430C433E0 for ; Fri, 10 Jul 2020 06:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5171F206E2 for ; Fri, 10 Jul 2020 06:02:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="J07Y2gm5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726787AbgGJGC4 (ORCPT ); Fri, 10 Jul 2020 02:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726288AbgGJGCx (ORCPT ); Fri, 10 Jul 2020 02:02:53 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23EB9C08C5DC for ; Thu, 9 Jul 2020 23:02:53 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id b9so1812715plx.6 for ; Thu, 09 Jul 2020 23:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=Oyd2oGqBVPyTAZ6JKFzEpbSr77ywHRgUekUG2FwE1cs=; b=J07Y2gm5zuILWzAzBMOo7yDMDUtUMb/Y8Nizn3WaDwf8021z99+kciMF7G3G6daKCL QhNbumaJhrt2UGJ3VPwE3FtUWphcnRsOd3oZNeAYOehVVdmkHlDJSCj3OFbCqLsmlxlh ruRX6eK6e1o0KvdHMX7zpNYqp0/xMh0BAPcbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=Oyd2oGqBVPyTAZ6JKFzEpbSr77ywHRgUekUG2FwE1cs=; b=kY/hWdD3pfDQXuBUIKQQSJGSKur1VF1m4UVI4AmFsyjZZelVlLBSpIqwh5Fzs0JTG/ +e4wYLq8Tq7r6dw1PLuR9pKVxXREgx2kc/q/7Xb4/24sra4q+UfSOQHDfHt5fXiIJoJA FCw0qe+0UwkW8hfczlcJTjWeZq9nrDiBbQBpymbzCp6a5uUxLPPGDNFS6ReWFAtuvsOc jAfByGcrPeQiEwsJOKASB/Dxclmz3t8YHrI1ESpip+BU+/kswgZlRfQjtoBlzHxgmOKN /1CuXqr1Ymrcd/iepAKz3cqYDq9DoAUohUGxKLuzXnAgd6y41V13gQmF5ojUisgKAK/k almg== X-Gm-Message-State: AOAM533aKQA/dh/Z5bbxGlTbUA28Z+kt3c+Y8aNYrzr0iimij7KTE42O FLhLQ/7C1/cDVkoJyIe7CAZRsw== X-Google-Smtp-Source: ABdhPJxQuO02QwzrJ7yQ4iqF18cqHc9AyeYIrNPWmubHIZDKuPvIBSEE6MzrekewNPVhTy6i4w1egg== X-Received: by 2002:a17:90a:2749:: with SMTP id o67mr3989699pje.183.1594360972481; Thu, 09 Jul 2020 23:02:52 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id h194sm4438382pfe.201.2020.07.09.23.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 23:02:51 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <87wo3setn8.wl-maz@kernel.org> References: <20200625001039.56174-1-john.stultz@linaro.org> <20200625001039.56174-4-john.stultz@linaro.org> <159315737502.62212.16093934831673347066@swboyd.mtv.corp.google.com> <87wo3setn8.wl-maz@kernel.org> Subject: Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module From: Stephen Boyd Cc: lkml , Andy Gross , Bjorn Andersson , Joerg Roedel , Thomas Gleixner , Jason Cooper , Linus Walleij , Maulik Shah , Lina Iyer , Saravana Kannan , Todd Kjos , Greg Kroah-Hartman , linux-arm-msm , iommu@lists.linux-foundation.org, linux-gpio@vger.kernel.org To: John Stultz , Marc Zyngier Date: Thu, 09 Jul 2020 23:02:50 -0700 Message-ID: <159436097057.1987609.13993891118929459851@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Quoting Marc Zyngier (2020-06-27 02:37:47) > On Sat, 27 Jun 2020 02:34:25 +0100, > John Stultz wrote: > >=20 > > On Fri, Jun 26, 2020 at 12:42 AM Stephen Boyd wro= te: > > > > > > > > > Is there any reason to use IRQCHIP_DECLARE if this can work as a > > > platform device driver? > > > > >=20 > > Hey! Thanks so much for the review! > >=20 > > Mostly it was done this way to minimize the change in the non-module > > case. But if you'd rather avoid the #ifdefery I'll respin it without. >=20 > That would certainly be my own preference. In general, IRQCHIP_DECLARE > and platform drivers should be mutually exclusive in the same driver: > if you can delay the probing and have it as a proper platform device, > then this should be the one true way. >=20 Does it work? I haven't looked in detail but I worry that the child irqdomain (i.e. pinctrl-msm) would need to delay probing until this parent irqdomain is registered. Or has the hierarchical irqdomain code been updated to handle the parent child relationship and wait for things to probe or be loaded?