From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659C9C433FE for ; Sat, 12 Dec 2020 10:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3076D23101 for ; Sat, 12 Dec 2020 10:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437288AbgLLKuH (ORCPT ); Sat, 12 Dec 2020 05:50:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:53886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405700AbgLLKty (ORCPT ); Sat, 12 Dec 2020 05:49:54 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49B592184D; Sat, 12 Dec 2020 10:49:13 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=localhost.localdomain) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1ko2Sd-000gY5-1w; Sat, 12 Dec 2020 10:49:11 +0000 From: Marc Zyngier To: Douglas Anderson , Thomas Gleixner , Linus Walleij Cc: Bjorn Andersson , Lina Iyer , linux-arm-msm@vger.kernel.org, Archana Sathyakumar , Maulik Shah , Neeraj Upadhyay , Srinivas Ramana , Rajendra Nayak , linux-kernel@vger.kernel.org, Stephen Boyd , linux-gpio@vger.kernel.org, Andy Gross Subject: Re: (subset) [PATCH v4 1/4] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling Date: Sat, 12 Dec 2020 10:48:55 +0000 Message-Id: <160777008910.485613.16353166280006901459.b4-ty@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201211141514.v4.1.I2702919afc253e2a451bebc3b701b462b2d22344@changeid> References: <20201211141514.v4.1.I2702919afc253e2a451bebc3b701b462b2d22344@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dianders@chromium.org, tglx@linutronix.de, linus.walleij@linaro.org, bjorn.andersson@linaro.org, ilina@codeaurora.org, linux-arm-msm@vger.kernel.org, asathyak@codeaurora.org, mkshah@codeaurora.org, neeraju@codeaurora.org, sramana@codeaurora.org, rnayak@codeaurora.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, linux-gpio@vger.kernel.org, agross@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, 11 Dec 2020 14:15:35 -0800, Douglas Anderson wrote: > We have a problem if we use gpio-keys and configure wakeups such that > we only want one edge to wake us up. AKA: > wakeup-event-action = ; > wakeup-source; > > Specifically we end up with a phantom interrupt that blocks suspend if > the line was already high and we want wakeups on rising edges (AKA we > want the GPIO to go low and then high again before we wake up). The > opposite is also problematic. > > [...] Applied to irq/irqchip-next, thanks! [1/4] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling commit: 2f5fbc4305d07725bfebaedb09e57271315691ef Cheers, M. -- Without deviation from the norm, progress is not possible.