linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Clément Leger" <cleger@kalray.eu>
To: Rob Herring <robh@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Hoan Tran <hoan@os.amperecomputing.com>,
	"open list, GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH 5/5] dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl
Date: Tue, 17 Dec 2019 11:01:45 +0100 (CET)	[thread overview]
Message-ID: <1686073939.96973784.1576576905628.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <20191216213959.GA957@bogus>

Hi Rob, 

Indeed, I could do that if you think that's a better option. Andy however suggested to always register a pinctrl controller.
Both options suits me. Let me know what option you want me to implement.

Thanks,

Clément

----- On 16 Dec, 2019, at 22:39, Rob Herring robh@kernel.org wrote:

> On Wed, Dec 04, 2019 at 02:52:59PM +0100, Clément Leger wrote:
>> 
>> ----- On 4 Dec, 2019, at 13:45, Andy Shevchenko andy.shevchenko@gmail.com wrote:
>> 
>> > On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@kalray.eu> wrote:
>> >>
>> >> Since the driver has been moved to pinctrl and now supports it, move the
>> >> documentation into pinctrl folder. In the same time, add documentation
>> >> for pinctrl properties such has snps,has-pinctrl and description of pin
>> >> alternate functions.
>> > 
>> >> +- snps,has-pinctrl : If present, register the pinctrl controller.
>> > 
>> > I'm wondering why we can't always assume pin control?
>> 
>> This hardware IP is configured when instantiated to include support for
>> muxing. If configured without support, the registers will exists but won't
>> configure anything.
>> I guess that it's not really a problem but it will lead to unusable
>> pin muxing.
> 
> Can't you determine this by the presence of child nodes?
> 
> Rob

      reply	other threads:[~2019-12-17 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 10:10 [PATCH 5/5] dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl Clement Leger
2019-12-04 12:45 ` Andy Shevchenko
2019-12-04 13:52   ` Clément Leger
2019-12-16 21:39     ` Rob Herring
2019-12-17 10:01       ` Clément Leger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1686073939.96973784.1576576905628.JavaMail.zimbra@kalray.eu \
    --to=cleger@kalray.eu \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hoan@os.amperecomputing.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).