linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC 0/2] gpiolib: Initial, basic support for shared GPIO lines
@ 2019-11-20 13:34 Peter Ujfalusi
  2019-11-20 13:34 ` [RFC 1/2] dt-bindings: gpio: Document shared GPIO line usage Peter Ujfalusi
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Peter Ujfalusi @ 2019-11-20 13:34 UTC (permalink / raw)
  To: linus.walleij, bgolaszewski, robh+dt
  Cc: linux-gpio, linux-kernel, m.szyprowski, broonie, mripard,
	p.zabel, devicetree

Hi,

The initial support can replace all use of GPIOD_FLAGS_BIT_NONEXCLUSIVE if the
shared GPIO is configured to follow pass through 'strategy' for the shared GPIO
pin.

I have only implemented DT support.

With the shared gpio support one can choose between three different strategy for
managing the shared gpio:
refcounted low: Keep the line low as long as there is at least one low
		request is registered
refcounted high: Keep the line high as long as there is at least one high
		request is registered
pass through: all requests are allowed to go through without refcounting.

Few shortcomings as of now:
- can not handle different GPIO_ACTIVE_ on the user side, both the root GPIO
  (which is shared) and clients must have the same GPIO_ACTIVE_ mode.
  We are using common gpio_desc.
  Like with GPIOD_FLAGS_BIT_NONEXCLUSIVE
- refcounting counts _all_ 1/0 requests coming from the users of the shared
  GPIO. This could cause issues if clients are using the gpiod API in unbalanced
  way.
  We would need to have separate tracking for each of the clients and agregate
  the level they are asking for at any moment. Basically a new gpio-chip on top
  of the real gpio pin can solve this.

Regards,
Peter
---
Peter Ujfalusi (2):
  dt-bindings: gpio: Document shared GPIO line usage
  gpiolib: Support for (output only) shared GPIO line

 .../devicetree/bindings/gpio/gpio.txt         |  66 +++++++++
 drivers/gpio/gpiolib-of.c                     |  28 +++-
 drivers/gpio/gpiolib.c                        | 132 ++++++++++++++++--
 drivers/gpio/gpiolib.h                        |  10 ++
 4 files changed, 223 insertions(+), 13 deletions(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-12-11  0:07 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-20 13:34 [RFC 0/2] gpiolib: Initial, basic support for shared GPIO lines Peter Ujfalusi
2019-11-20 13:34 ` [RFC 1/2] dt-bindings: gpio: Document shared GPIO line usage Peter Ujfalusi
2019-11-22 12:10   ` Linus Walleij
2019-11-22 13:36     ` Peter Ujfalusi
2019-11-28 10:06       ` Linus Walleij
2019-12-02 21:31         ` Peter Ujfalusi
2019-12-11  0:06           ` Linus Walleij
2019-12-03 23:51         ` Rob Herring
2019-12-10 23:54           ` Linus Walleij
2019-11-20 13:34 ` [RFC 2/2] gpiolib: Support for (output only) shared GPIO line Peter Ujfalusi
2019-11-22 12:22   ` Linus Walleij
2019-11-22 15:14     ` Peter Ujfalusi
2019-11-20 13:49 ` [RFC 0/2] gpiolib: Initial, basic support for shared GPIO lines Peter Ujfalusi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).