From: Matthias Brugger <matthias.bgg@gmail.com>
To: Hanks Chen <hanks.chen@mediatek.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Sean Wang <sean.wang@kernel.org>,
mtk01761 <wendell.lin@mediatek.com>,
Andy Teng <andy.teng@mediatek.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
wsd_upstream@mediatek.com, CC Hwang <cc.hwang@mediatek.com>,
Loda Chou <loda.chou@mediatek.com>
Subject: Re: [PATCH v8 6/7] arm64: dts: add dts nodes for MT6779
Date: Wed, 22 Jul 2020 00:09:06 +0200 [thread overview]
Message-ID: <1eb11f7f-603a-4aa9-92c5-1e18e6e2ce01@gmail.com> (raw)
In-Reply-To: <1595311242.5599.3.camel@mtkswgap22>
On 21/07/2020 08:00, Hanks Chen wrote:
> On Mon, 2020-07-20 at 18:13 +0200, Matthias Brugger wrote:
>>
>> On 16/07/2020 06:04, Hanks Chen wrote:
>>>>> + uart2: serial@11004000 {
>>>>> + compatible = "mediatek,mt6779-uart",
>>>>> + "mediatek,mt6577-uart";
>>>>> + reg = <0 0x11004000 0 0x400>;
>>>>> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_LOW>;
>>>>> + clocks = <&clk26m>, <&infracfg_ao CLK_INFRA_UART2>;
>>>>> + clock-names = "baud", "bus";
>>>>> + status = "disabled";
>>>>> + };
>>>>
>>>> Devicetree describes the HW we have. As far as I know, we have 4 UARTs on
>>>> MT6779. So we should list them all here.
>>>>
>>>
>>> Actually, We have only 3 UARTs HW on MT6779, but have 4 UART clk in
>>> header file of clk.
>>
>> Correct, I got confused by the four clocks.
>> With that clarified I'm fine with the patch and will take it as soon as the
>> clock driver patch is accepted.
>>
>> Regards,
>> Matthias
>>
> Got it, I send a new serial to fix the redundant UART clk
> https://lkml.org/lkml/2020/7/21/45
>
Ok, also I was talking about:
[PATCH v8 7/7] clk: mediatek: add UART0 clock support
Regards,
Matthias
next prev parent reply other threads:[~2020-07-21 22:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 9:19 [PATCH v8 0/7] Add basic SoC Support for Mediatek MT6779 SoC Hanks Chen
2020-07-14 9:19 ` [PATCH v8 1/7] pinctrl: mediatek: update pinmux definitions for mt6779 Hanks Chen
2020-07-14 20:34 ` Rob Herring
2020-07-16 13:49 ` Linus Walleij
2020-07-14 9:19 ` [PATCH v8 2/7] dt-bindings: pinctrl: add bindings for MediaTek MT6779 SoC Hanks Chen
2020-07-14 20:35 ` Rob Herring
2020-07-14 9:19 ` [PATCH v8 3/7] pinctrl: mediatek: avoid virtual gpio trying to set reg Hanks Chen
2020-07-14 20:47 ` Sean Wang
2020-07-14 9:19 ` [PATCH v8 4/7] pinctrl: mediatek: add pinctrl support for MT6779 SoC Hanks Chen
2020-07-14 9:20 ` [PATCH v8 5/7] pinctrl: mediatek: add mt6779 eint support Hanks Chen
2020-07-14 9:20 ` [PATCH v8 6/7] arm64: dts: add dts nodes for MT6779 Hanks Chen
2020-07-14 18:14 ` Matthias Brugger
2020-07-16 4:04 ` Hanks Chen
2020-07-20 16:13 ` Matthias Brugger
2020-07-21 6:00 ` Hanks Chen
2020-07-21 22:09 ` Matthias Brugger [this message]
2020-07-14 9:20 ` [PATCH v8 7/7] clk: mediatek: add UART0 clock support Hanks Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb11f7f-603a-4aa9-92c5-1e18e6e2ce01@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=andy.teng@mediatek.com \
--cc=cc.hwang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hanks.chen@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=loda.chou@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
--cc=wendell.lin@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).