From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] gpio: of: Break out OF-only code
Date: Tue, 16 Jul 2019 20:00:56 +0300 [thread overview]
Message-ID: <20190716170056.GQ9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190716123918.26004-1-linus.walleij@linaro.org>
On Tue, Jul 16, 2019 at 02:39:18PM +0200, Linus Walleij wrote:
> The core gpiolib should not contain any OF/device tree-only
> code. Try to break out the main part of it and push it down
> into the optional gpiolib-of.c part of the library.
>
> Create a local gpiolib-of.h header and move stuff around a
> bit to get a clean cut.
Good one!
One question below, though.
> drivers/gpio/gpiolib-of.c | 114 ++++++++++++++++++++++++++++++++++++++
> drivers/gpio/gpiolib.c | 113 +++----------------------------------
> drivers/gpio/gpiolib.h | 27 ---------
> 3 files changed, 122 insertions(+), 132 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 2bc0bcd7a410..00ed60304cd4 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -21,6 +21,34 @@
> #include <linux/gpio/machine.h>
>
> #include "gpiolib.h"
> +#include "gpiolib-of.h"
Did I miss something? Where is the file?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-07-16 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 12:39 [PATCH] gpio: of: Break out OF-only code Linus Walleij
2019-07-16 17:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716170056.GQ9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).