From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 370B4C76191 for ; Thu, 18 Jul 2019 06:51:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C2622173E for ; Thu, 18 Jul 2019 06:51:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="BQUMM2Pq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbfGRGvp (ORCPT ); Thu, 18 Jul 2019 02:51:45 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:36276 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbfGRGvp (ORCPT ); Thu, 18 Jul 2019 02:51:45 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x6I6p9ST017611; Thu, 18 Jul 2019 15:51:10 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x6I6p9ST017611 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1563432670; bh=ZhDfduBxSN7i25VRGia8YNv8px3x7GeUSF1hPbqj3LU=; h=From:To:Cc:Subject:Date:From; b=BQUMM2PqBjQldXgRks4B2tHXeL+fCcUba6f9gjeYYXVgbhLUkboZ4cPmrsDhO8ziF +oMFxoX3052q3b4eS03q7yLzplHv8JHGBfzg81gUfb40uff4unZXHwApfakjniUph2 uM5HrDTa4OGwkX5NaOxpUYd9e1dwBhh+QHr+V2/Q7fQ2osiYA2Ouj1H5Gr+w0ME9Fc 5gQbyEMJNAiPjrfIOnRo1KSNmlBB7o1d3Af438PZZUt667PYZCde8HDZ2ORvy4ySGa ORNgsvgH6E6rrhgYvG6/k73fnAobar9HMbMxzlXnCkLs2YdUvNpqOyWhSt9WMgt/H4 NRC6oGRR0FZVg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-gpio@vger.kernel.org, Linus Walleij Cc: Stephen Boyd , Masahiro Yamada , Bartosz Golaszewski , linux-kernel@vger.kernel.org Subject: [PATCH] gpio: refactor gpiochip_allocate_mask() with bitmap_alloc() Date: Thu, 18 Jul 2019 15:51:01 +0900 Message-Id: <20190718065101.26994-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Refactor gpiochip_allocate_mask() slightly by using bitmap_alloc(). I used bitmap_free() for the corresponding free parts. Actually, bitmap_free() is a wrapper of kfree(), but I did this for consistency. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpiolib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 3ee99d070608..5ac2daa01a53 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -350,7 +350,7 @@ static unsigned long *gpiochip_allocate_mask(struct gpio_chip *chip) { unsigned long *p; - p = kmalloc_array(BITS_TO_LONGS(chip->ngpio), sizeof(*p), GFP_KERNEL); + p = bitmap_alloc(chip->ngpio, GFP_KERNEL); if (!p) return NULL; @@ -391,7 +391,7 @@ static int gpiochip_init_valid_mask(struct gpio_chip *gpiochip) static void gpiochip_free_valid_mask(struct gpio_chip *gpiochip) { - kfree(gpiochip->valid_mask); + bitmap_free(gpiochip->valid_mask); gpiochip->valid_mask = NULL; } @@ -1626,7 +1626,7 @@ static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip) static void gpiochip_irqchip_free_valid_mask(struct gpio_chip *gpiochip) { - kfree(gpiochip->irq.valid_mask); + bitmap_free(gpiochip->irq.valid_mask); gpiochip->irq.valid_mask = NULL; } -- 2.17.1