From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 723D8C31E40 for ; Mon, 12 Aug 2019 15:27:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 452EE2085A for ; Mon, 12 Aug 2019 15:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565623656; bh=vbVr9jjl22J0zb0ffZlickEWyD1dg9kUn83VsAuo2gc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iS9lHvQOwcPlE/ZU5fQQs3rWEj45m557VbEgv8dhs3+a3KNwrC5dfkPcenUE91+3w LLs4SkBzan8yFLEVnqedPf/r4x+pK9am7PJ/XSF/1kD0+dYiKKTGHwmgMzky62nGIM 5J7AW7L0KOsMafrvtCwWgedUk5b60REctD2SgFyY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727263AbfHLP1g (ORCPT ); Mon, 12 Aug 2019 11:27:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:42850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbfHLP1f (ORCPT ); Mon, 12 Aug 2019 11:27:35 -0400 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7261B2070C; Mon, 12 Aug 2019 15:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565623655; bh=vbVr9jjl22J0zb0ffZlickEWyD1dg9kUn83VsAuo2gc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pV7VfsZmTSwqdx7hJ19BAsFa2hxZSxzosbwfvKgUv/wMxXD6fuH8M5J9Pqve32BHM LGi33XJvc9mlNIxCCG7JnfYNDqfXjO0tCKMWDhPFbuQ3/kuQHKbGdxCNTOyTWARIyc iGsnxyY//nXtgglWqzmEM9Z93K1D54pAY09YstTk= Date: Mon, 12 Aug 2019 17:27:25 +0200 From: Shawn Guo To: Hui Song Cc: Li Yang , Rob Herring , Mark Rutland , Linus Walleij , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v1 2/3] arm64: dts: fix gpio node Message-ID: <20190812152723.GK27041@X250> References: <20190808101628.36782-1-hui.song_1@nxp.com> <20190808101628.36782-2-hui.song_1@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808101628.36782-2-hui.song_1@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Aug 08, 2019 at 06:16:27PM +0800, Hui Song wrote: > From: Song Hui > > Update the nodes to include little-endian > property to be consistent with the hardware > and add ls1088a gpio specify compatible. > > Signed-off-by: Song Hui The prefix should be more specific, like 'arm64: dts: ls1088a: ...' Shawn > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 20f5ebd..d58d203 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -269,43 +269,47 @@ > }; > > gpio0: gpio@2300000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2300000 0x0 0x10000>; > interrupts = <0 36 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > gpio1: gpio@2310000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2310000 0x0 0x10000>; > interrupts = <0 36 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > gpio2: gpio@2320000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2320000 0x0 0x10000>; > interrupts = <0 37 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > gpio3: gpio@2330000 { > - compatible = "fsl,qoriq-gpio"; > + compatible = "fsl,ls1088a-gpio", "fsl,qoriq-gpio"; > reg = <0x0 0x2330000 0x0 0x10000>; > interrupts = <0 37 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + little-endian; > }; > > ifc: ifc@2240000 { > -- > 2.9.5 >