From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pavel Machek <pavel@denx.de>
Cc: Stefan Roese <sr@denx.de>,
linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] serial: mctrl_gpio: Support all GPIO suffixes (gpios vs gpio)
Date: Tue, 13 Aug 2019 15:15:54 +0300 [thread overview]
Message-ID: <20190813121554.GU30120@smile.fi.intel.com> (raw)
In-Reply-To: <20190813114258.GA11559@amd>
On Tue, Aug 13, 2019 at 01:42:58PM +0200, Pavel Machek wrote:
> On Mon 2019-08-12 13:53:07, Andy Shevchenko wrote:
> > On Thu, Aug 08, 2019 at 03:59:36PM +0200, Stefan Roese wrote:
> > > On 08.08.19 15:48, Andy Shevchenko wrote:
> > > > On Thu, Aug 08, 2019 at 03:25:43PM +0200, Stefan Roese wrote:
> > I tried hard to find an evidence of this in Linux kernel, I assume that comes
> > from DT compiler or something, but fail. Linux kernel OF properties handling is
> > written in the assumption of arbitrary length of the property name.
> >
> > It might be that my hard was not hard at all and I missed something.
> >
> > > > Or maybe we can still continue using kasprintf() approach?
> > >
> > > Frankly, I was feeling a bit uncomfortable with this memory allocation
> > > in a loop. And Pavel also commented on this:
> > >
> > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2066286.html
> >
> > If memory allocator fails, it's a big issue, and what will happen next probably
> > much less important.
>
> Not... really. With "too big" allocations, it will fail.
Yeah, or with relatively small if memory is too much fragmented.
But we are talking about really small allocations here in most cases, right?
> Anyway, my point is that allocating in a loop for this is slow and
> ugly. If we don't have a maximum property length, we should probably
> invent some. I mean, we can agree that 64KB property name is not okay,
> right?
My point that is should be declared on the level of property API.
Restricting it on the level of one, 'client' to that API, framework is not
a solution.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-08-13 12:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 13:25 [PATCH 1/2] gpiolib: Add for_each_gpio_suffix() helper Stefan Roese
2019-08-08 13:25 ` [PATCH 2/2] serial: mctrl_gpio: Support all GPIO suffixes (gpios vs gpio) Stefan Roese
2019-08-08 13:48 ` Andy Shevchenko
2019-08-08 13:59 ` Stefan Roese
2019-08-12 10:53 ` Andy Shevchenko
2019-08-13 11:42 ` Pavel Machek
2019-08-13 12:15 ` Andy Shevchenko [this message]
2019-08-12 11:17 ` Geert Uytterhoeven
2019-08-12 11:53 ` Stefan Roese
2019-08-12 12:11 ` Geert Uytterhoeven
2019-08-12 12:31 ` Andy Shevchenko
2019-08-08 13:44 ` [PATCH 1/2] gpiolib: Add for_each_gpio_suffix() helper Andy Shevchenko
2019-08-08 14:13 ` Stefan Roese
2019-08-10 8:27 ` Linus Walleij
2019-08-10 8:48 ` Greg Kroah-Hartman
2019-08-12 11:18 ` Geert Uytterhoeven
2019-08-14 8:48 ` Linus Walleij
2019-08-14 13:17 ` Stefan Roese
2019-08-14 13:32 ` Geert Uytterhoeven
2019-08-14 13:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813121554.GU30120@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@denx.de \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).