From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Alban Bedel <albeu@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 7/9] gpio: htc-egpio: use devm_platform_ioremap_resource_nocache()
Date: Thu, 29 Aug 2019 16:37:40 +0200 [thread overview]
Message-ID: <20190829143742.24726-8-brgl@bgdev.pl> (raw)
In-Reply-To: <20190829143742.24726-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Use the new devm_platform_ioremap_resource_nocache() helper for memory
range mapping instead of devm_ioremap_nocache() combined with a call to
platform_get_resource().
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/gpio/gpio-htc-egpio.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-htc-egpio.c b/drivers/gpio/gpio-htc-egpio.c
index 9d3ac51a765c..7d8548e03226 100644
--- a/drivers/gpio/gpio-htc-egpio.c
+++ b/drivers/gpio/gpio-htc-egpio.c
@@ -295,14 +295,13 @@ static int __init egpio_probe(struct platform_device *pdev)
ei->chained_irq = res->start;
/* Map egpio chip into virtual address space. */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
+ ei->base_addr = devm_platform_ioremap_resource_nocache(pdev, 0);
+ if (IS_ERR(ei->base_addr)) {
+ ret = PTR_ERR(ei->base_addr);
goto fail;
- ei->base_addr = devm_ioremap_nocache(&pdev->dev, res->start,
- resource_size(res));
- if (!ei->base_addr)
- goto fail;
- pr_debug("EGPIO phys=%08x virt=%p\n", (u32)res->start, ei->base_addr);
+ }
+ pr_debug("EGPIO phys=%08x virt=%p\n",
+ virt_to_phys(ei->base_addr), ei->base_addr);
if ((pdata->bus_width != 16) && (pdata->bus_width != 32))
goto fail;
--
2.21.0
next prev parent reply other threads:[~2019-08-29 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:37 [PATCH 0/9] drivers: add new variants of devm_platform_ioremap_resource() Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 1/9] Documentation: devres: add missing entry for devm_platform_ioremap_resource() Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 2/9] lib: devres: prepare devm_ioremap_resource() for more variants Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 3/9] lib: devres: provide new variants for devm_ioremap_resource() Bartosz Golaszewski
2019-08-29 15:09 ` Arnd Bergmann
2019-08-29 14:37 ` [PATCH 4/9] drivers: provide new variants of devm_platform_ioremap_resource() Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 5/9] gpio: em: use devm_platform_ioremap_resource_nocache() Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 6/9] gpio: ath79: " Bartosz Golaszewski
2019-08-29 14:37 ` Bartosz Golaszewski [this message]
2019-08-29 14:37 ` [PATCH 8/9] gpio: xgene: " Bartosz Golaszewski
2019-08-29 14:37 ` [PATCH 9/9] misc: sram: use devm_platform_ioremap_resource_wc() Bartosz Golaszewski
2019-08-29 14:48 ` [PATCH 0/9] drivers: add new variants of devm_platform_ioremap_resource() Geert Uytterhoeven
2019-08-30 15:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829143742.24726-8-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=Julia.Lawall@lip6.fr \
--cc=albeu@free.fr \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).