* [gpio:devel 53/53] drivers//gpio/gpiolib.c:1402:2: error: 'status' undeclared; did you mean 'kstatfs'?
@ 2019-09-05 13:31 kbuild test robot
2019-09-05 21:22 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-09-05 13:31 UTC (permalink / raw)
Cc: kbuild-all, linux-gpio, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 8910 bytes --]
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/linusw/linux-gpio.git devel
head: 151a41014bff92f353263cadc051435dc9c3258e
commit: 151a41014bff92f353263cadc051435dc9c3258e [53/53] Merge tag 'v5.3-rc7' into devel
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
git checkout 151a41014bff92f353263cadc051435dc9c3258e
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers//gpio/gpiolib.c: In function 'gpiochip_add_data_with_key':
>> drivers//gpio/gpiolib.c:1402:2: error: 'status' undeclared (first use in this function); did you mean 'kstatfs'?
status = gpiochip_irqchip_init_valid_mask(chip);
^~~~~~
kstatfs
drivers//gpio/gpiolib.c:1402:2: note: each undeclared identifier is reported only once for each function it appears in
vim +1402 drivers//gpio/gpiolib.c
f23f1516b6757c Shiraz Hashim 2012-10-27 1365
d377f56f34f5bc Linus Walleij 2019-07-16 1366 ret = gpiochip_set_desc_names(chip);
d377f56f34f5bc Linus Walleij 2019-07-16 1367 if (ret)
5f3ca7329b049b Markus Pargmann 2015-08-14 1368 goto err_remove_from_list;
5f3ca7329b049b Markus Pargmann 2015-08-14 1369
d377f56f34f5bc Linus Walleij 2019-07-16 1370 ret = gpiochip_alloc_valid_mask(chip);
d377f56f34f5bc Linus Walleij 2019-07-16 1371 if (ret)
48057ed1840fde Linus Walleij 2019-08-20 1372 goto err_remove_from_list;
e0d89728981393 Thierry Reding 2017-11-07 1373
d377f56f34f5bc Linus Walleij 2019-07-16 1374 ret = of_gpiochip_add(chip);
d377f56f34f5bc Linus Walleij 2019-07-16 1375 if (ret)
48057ed1840fde Linus Walleij 2019-08-20 1376 goto err_free_gpiochip_mask;
28355f81969962 Tomeu Vizoso 2015-07-14 1377
d377f56f34f5bc Linus Walleij 2019-07-16 1378 ret = gpiochip_init_valid_mask(chip);
d377f56f34f5bc Linus Walleij 2019-07-16 1379 if (ret)
357798909164bf Geert Uytterhoeven 2019-04-24 1380 goto err_remove_of_chip;
f8ec92a9f63b3b Ricardo Ribalda Delgado 2018-10-05 1381
3edfb7bd76bd1c Ricardo Ribalda Delgado 2018-10-05 1382 for (i = 0; i < chip->ngpio; i++) {
3edfb7bd76bd1c Ricardo Ribalda Delgado 2018-10-05 1383 struct gpio_desc *desc = &gdev->descs[i];
3edfb7bd76bd1c Ricardo Ribalda Delgado 2018-10-05 1384
d95da993383c78 Chris Packham 2019-07-08 1385 if (chip->get_direction && gpiochip_line_is_valid(chip, i)) {
d95da993383c78 Chris Packham 2019-07-08 1386 if (!chip->get_direction(chip, i))
d95da993383c78 Chris Packham 2019-07-08 1387 set_bit(FLAG_IS_OUT, &desc->flags);
3edfb7bd76bd1c Ricardo Ribalda Delgado 2018-10-05 1388 else
d95da993383c78 Chris Packham 2019-07-08 1389 clear_bit(FLAG_IS_OUT, &desc->flags);
d95da993383c78 Chris Packham 2019-07-08 1390 } else {
d95da993383c78 Chris Packham 2019-07-08 1391 if (!chip->direction_input)
d95da993383c78 Chris Packham 2019-07-08 1392 set_bit(FLAG_IS_OUT, &desc->flags);
3edfb7bd76bd1c Ricardo Ribalda Delgado 2018-10-05 1393 else
d95da993383c78 Chris Packham 2019-07-08 1394 clear_bit(FLAG_IS_OUT, &desc->flags);
d95da993383c78 Chris Packham 2019-07-08 1395 }
3edfb7bd76bd1c Ricardo Ribalda Delgado 2018-10-05 1396 }
3edfb7bd76bd1c Ricardo Ribalda Delgado 2018-10-05 1397
664e3e5ac64c8a Mika Westerberg 2014-01-08 1398 acpi_gpiochip_add(chip);
391c970c0dd110 Anton Vorontsov 2010-06-08 1399
a411e81e61df24 Bartosz Golaszewski 2018-04-10 1400 machine_gpiochip_add(chip);
a411e81e61df24 Bartosz Golaszewski 2018-04-10 1401
48057ed1840fde Linus Walleij 2019-08-20 @1402 status = gpiochip_irqchip_init_valid_mask(chip);
48057ed1840fde Linus Walleij 2019-08-20 1403 if (status)
48057ed1840fde Linus Walleij 2019-08-20 1404 goto err_remove_acpi_chip;
48057ed1840fde Linus Walleij 2019-08-20 1405
48057ed1840fde Linus Walleij 2019-08-20 1406 status = gpiochip_add_irqchip(chip, lock_key, request_key);
48057ed1840fde Linus Walleij 2019-08-20 1407 if (status)
48057ed1840fde Linus Walleij 2019-08-20 1408 goto err_remove_irqchip_mask;
48057ed1840fde Linus Walleij 2019-08-20 1409
3c702e9987e261 Linus Walleij 2015-10-21 1410 /*
3c702e9987e261 Linus Walleij 2015-10-21 1411 * By first adding the chardev, and then adding the device,
3c702e9987e261 Linus Walleij 2015-10-21 1412 * we get a device node entry in sysfs under
3c702e9987e261 Linus Walleij 2015-10-21 1413 * /sys/bus/gpio/devices/gpiochipN/dev that can be used for
3c702e9987e261 Linus Walleij 2015-10-21 1414 * coldplug of device nodes and other udev business.
159f3cd92f17c6 Guenter Roeck 2016-03-31 1415 * We can do this only if gpiolib has been initialized.
159f3cd92f17c6 Guenter Roeck 2016-03-31 1416 * Otherwise, defer until later.
3c702e9987e261 Linus Walleij 2015-10-21 1417 */
159f3cd92f17c6 Guenter Roeck 2016-03-31 1418 if (gpiolib_initialized) {
d377f56f34f5bc Linus Walleij 2019-07-16 1419 ret = gpiochip_setup_dev(gdev);
d377f56f34f5bc Linus Walleij 2019-07-16 1420 if (ret)
48057ed1840fde Linus Walleij 2019-08-20 1421 goto err_remove_irqchip;
159f3cd92f17c6 Guenter Roeck 2016-03-31 1422 }
cedb1881ba32f7 Anton Vorontsov 2010-06-08 1423 return 0;
3bae4811fb6d0b Zhangfei Gao 2013-06-09 1424
48057ed1840fde Linus Walleij 2019-08-20 1425 err_remove_irqchip:
48057ed1840fde Linus Walleij 2019-08-20 1426 gpiochip_irqchip_remove(chip);
48057ed1840fde Linus Walleij 2019-08-20 1427 err_remove_irqchip_mask:
48057ed1840fde Linus Walleij 2019-08-20 1428 gpiochip_irqchip_free_valid_mask(chip);
357798909164bf Geert Uytterhoeven 2019-04-24 1429 err_remove_acpi_chip:
225fce83cb72e1 Johan Hovold 2015-01-12 1430 acpi_gpiochip_remove(chip);
357798909164bf Geert Uytterhoeven 2019-04-24 1431 err_remove_of_chip:
6d86750ce62391 Johan Hovold 2015-05-04 1432 gpiochip_free_hogs(chip);
225fce83cb72e1 Johan Hovold 2015-01-12 1433 of_gpiochip_remove(chip);
357798909164bf Geert Uytterhoeven 2019-04-24 1434 err_free_gpiochip_mask:
726cb3ba49692b Stephen Boyd 2018-03-23 1435 gpiochip_free_valid_mask(chip);
5f3ca7329b049b Markus Pargmann 2015-08-14 1436 err_remove_from_list:
225fce83cb72e1 Johan Hovold 2015-01-12 1437 spin_lock_irqsave(&gpio_lock, flags);
ff2b1359229927 Linus Walleij 2015-10-20 1438 list_del(&gdev->list);
3bae4811fb6d0b Zhangfei Gao 2013-06-09 1439 spin_unlock_irqrestore(&gpio_lock, flags);
476e2fc5cd430b Guenter Roeck 2016-03-31 1440 err_free_label:
fcf273e5807976 Bartosz Golaszewski 2017-12-14 1441 kfree_const(gdev->label);
476e2fc5cd430b Guenter Roeck 2016-03-31 1442 err_free_descs:
476e2fc5cd430b Guenter Roeck 2016-03-31 1443 kfree(gdev->descs);
a05a1404999959 Vladimir Zapolskiy 2018-11-02 1444 err_free_ida:
ff2b1359229927 Linus Walleij 2015-10-20 1445 ida_simple_remove(&gpio_ida, gdev->id);
a05a1404999959 Vladimir Zapolskiy 2018-11-02 1446 err_free_gdev:
d2876d08d86f22 David Brownell 2008-02-04 1447 /* failures here can mean systems won't boot... */
1777fc97302997 Marcel Ziswiler 2018-07-20 1448 pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
fdeb8e1547cb9d Linus Walleij 2016-02-10 1449 gdev->base, gdev->base + gdev->ngpio - 1,
d377f56f34f5bc Linus Walleij 2019-07-16 1450 chip->label ? : "generic", ret);
fdeb8e1547cb9d Linus Walleij 2016-02-10 1451 kfree(gdev);
d377f56f34f5bc Linus Walleij 2019-07-16 1452 return ret;
d2876d08d86f22 David Brownell 2008-02-04 1453 }
959bc7b22bd25a Thierry Reding 2017-11-07 1454 EXPORT_SYMBOL_GPL(gpiochip_add_data_with_key);
d2876d08d86f22 David Brownell 2008-02-04 1455
:::::: The code at line 1402 was first introduced by commit
:::::: 48057ed1840fde9239b1e000bea1a0a1f07c5e99 gpio: Fix irqchip initialization order
:::::: TO: Linus Walleij <linus.walleij@linaro.org>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28202 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [gpio:devel 53/53] drivers//gpio/gpiolib.c:1402:2: error: 'status' undeclared; did you mean 'kstatfs'?
2019-09-05 13:31 [gpio:devel 53/53] drivers//gpio/gpiolib.c:1402:2: error: 'status' undeclared; did you mean 'kstatfs'? kbuild test robot
@ 2019-09-05 21:22 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-09-05 21:22 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, open list:GPIO SUBSYSTEM, Linus Walleij
On Thu, Sep 5, 2019 at 4:04 PM kbuild test robot <lkp@intel.com> wrote:
> tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/linusw/linux-gpio.git devel
> head: 151a41014bff92f353263cadc051435dc9c3258e
> commit: 151a41014bff92f353263cadc051435dc9c3258e [53/53] Merge tag 'v5.3-rc7' into devel
> config: x86_64-lkp (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
> reproduce:
> git checkout 151a41014bff92f353263cadc051435dc9c3258e
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers//gpio/gpiolib.c: In function 'gpiochip_add_data_with_key':
> >> drivers//gpio/gpiolib.c:1402:2: error: 'status' undeclared (first use in this function); did you mean 'kstatfs'?
> status = gpiochip_irqchip_init_valid_mask(chip);
> ^~~~~~
> kstatfs
> drivers//gpio/gpiolib.c:1402:2: note: each undeclared identifier is reported only once for each function it appears in
Looks like the merge resolution in 151a41014bff92f353263cadc051435dc9c3258e
replaced "status" by "ret", but forgot to update 4 occurrences.
Note that it's still broken in current gpio/for-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-05 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 13:31 [gpio:devel 53/53] drivers//gpio/gpiolib.c:1402:2: error: 'status' undeclared; did you mean 'kstatfs'? kbuild test robot
2019-09-05 21:22 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).