From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D6FCC433EF for ; Mon, 9 Sep 2019 09:22:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CA752196E for ; Mon, 9 Sep 2019 09:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728861AbfIIJWQ (ORCPT ); Mon, 9 Sep 2019 05:22:16 -0400 Received: from mga18.intel.com ([134.134.136.126]:9306 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728706AbfIIJWP (ORCPT ); Mon, 9 Sep 2019 05:22:15 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 02:22:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="213859213" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 09 Sep 2019 02:22:13 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i7FsB-00061C-QA; Mon, 09 Sep 2019 12:22:11 +0300 Date: Mon, 9 Sep 2019 12:22:11 +0300 From: Andy Shevchenko To: Arnd Bergmann Cc: Mika Westerberg , Linus Walleij , Chris Chiu , Kai-Heng Feng , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] pinctrl: intel: mark intel_pin_to_gpio __maybe_unused Message-ID: <20190909092211.GN2680@smile.fi.intel.com> References: <20190906185231.1081695-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190906185231.1081695-1-arnd@arndb.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Sep 06, 2019 at 08:51:59PM +0200, Arnd Bergmann wrote: > The intel_pin_to_gpio() function is only called by the > PM support functions and causes a warning when those are disabled: > > drivers/pinctrl/intel/pinctrl-intel.c:841:12: error: unused function 'intel_pin_to_gpio' [-Werror,-Wunused-function] > > Mark it __maybe_unused to suppress the warning. > Acked-by: Andy Shevchenko > Suggested-by: Andy Shevchenko > Signed-off-by: Arnd Bergmann > --- > v2: use __maybe_unused instead of moving the code > --- > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c > index d66fe2b4221b..1f13bcd0e4e1 100644 > --- a/drivers/pinctrl/intel/pinctrl-intel.c > +++ b/drivers/pinctrl/intel/pinctrl-intel.c > @@ -838,7 +838,7 @@ static int intel_gpio_to_pin(struct intel_pinctrl *pctrl, unsigned int offset, > * > * Translate the pin number of pinctrl to GPIO offset > */ > -static int intel_pin_to_gpio(struct intel_pinctrl *pctrl, int pin) > +static __maybe_unused int intel_pin_to_gpio(struct intel_pinctrl *pctrl, int pin) > { > const struct intel_community *community; > const struct intel_padgroup *padgrp; > -- > 2.20.0 > -- With Best Regards, Andy Shevchenko