From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8D02C04EBF for ; Mon, 23 Sep 2019 15:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CA7D207FD for ; Mon, 23 Sep 2019 15:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731686AbfIWPDj (ORCPT ); Mon, 23 Sep 2019 11:03:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:26036 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbfIWPDi (ORCPT ); Mon, 23 Sep 2019 11:03:38 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 08:03:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,540,1559545200"; d="scan'208";a="203140575" Received: from kuha.fi.intel.com ([10.237.72.53]) by fmsmga001.fm.intel.com with SMTP; 23 Sep 2019 08:03:34 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 23 Sep 2019 18:03:33 +0300 Date: Mon, 23 Sep 2019 18:03:33 +0300 From: Heikki Krogerus To: Laurent Pinchart Cc: Dmitry Torokhov , Linus Walleij , Andy Shevchenko , Mika Westerberg , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Neil Armstrong , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 06/11] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() Message-ID: <20190923150333.GD16243@kuha.fi.intel.com> References: <20190911075215.78047-1-dmitry.torokhov@gmail.com> <20190911075215.78047-7-dmitry.torokhov@gmail.com> <20190920231228.GH12672@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190920231228.GH12672@pendragon.ideasonboard.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Sep 21, 2019 at 02:12:28AM +0300, Laurent Pinchart wrote: > Hi Dmitry, > > (CC'ing Heikki as the original author of software nodes support) > > Thank you for the patch. > > On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote: > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit > > s/bit/but/ > > > works with arbitrary firmware node. > > > > Signed-off-by: Dmitry Torokhov > > Reviewed-by: Laurent Pinchart > > On a side note, as I'm not very familiar with software nodes, I tried to > see how they are to be used, and it seems they are completely > undocumented :-( Heikki, is this something that could be fixed ? OK. I'll start writing API documentation for it. thanks, -- heikki