From: Kent Gibson <email@example.com> To: Drew Fustini <firstname.lastname@example.org> Cc: Bartosz Golaszewski <email@example.com>, "open list:GPIO SUBSYSTEM" <firstname.lastname@example.org>, Linus Walleij <email@example.com>, Thomas Petazzoni <firstname.lastname@example.org> Subject: Re: [RFC] gpio: expose pull-up/pull-down line flags to userspace Date: Wed, 9 Oct 2019 13:23:46 +0000 Message-ID: <20191009132346.GA1384@firefly> (raw) In-Reply-To: <20191009125727.GA10800@x1> On Wed, Oct 09, 2019 at 02:57:27PM +0200, Drew Fustini wrote: > > On Wed, Oct 09, 2019 at 02:55:24PM +0800, Kent Gibson wrote: > > Safe to assume your code is in your topic/gpio-uapi-config branch? > > I hope so, cos I've forked from that into github.com/warthog618/linux > > and have started working on it. > > > > So far I've added pull up/down support to lineevent_create, and > > added default_values to the gpiohandle_config (for setting outputs). > > Currently looking at implementing the actual set config, and sucking > > on whether that is best done by refactoring bit out of > > linehandle_create. > > > > Will sort that into patches once it is in a fit state. > > Feel free to poke me if I'm going off track. > > > > Cheers, > > Kent. > > Great to see that work on this capability is moving foward. I also have > spare time so I'm eager to help however I can. > > I had been working from the kernel.org torvalds/linux.git master to > create a patch and used 'git send-email' to post a patch. It is > interesting that Bartosz and you have forks of linux where you created > topic branches. I just added warthog618/linux as a remote so I can view > and try out your commits. > Sorry that the branch is a munge of the pull up/down and set config changes. And I have no idea how I'm going to sort this into a reasonable patch sequence, but I'll burn that bridge when I get to it. I'm reasonably happy with the state of the pull up/down. That is passing all my tests on gpio-mockup - other than the actual value being pulled - but that is because gpio-mockup needs to be updated. Which is next on the todo list. Along with building a Pi kernel to test real hardware. I'd steer clear of the SET_CONFIG changes for the moment - those are totally untested. But I guess you don't have any code to call the ioctl yet anyway... That is slightly further down the todo list. Cheers, Kent.
next prev parent reply index Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-21 10:25 Drew Fustini 2019-09-23 8:38 ` Bartosz Golaszewski 2019-10-02 11:10 ` Drew Fustini 2019-10-03 12:47 ` Linus Walleij 2019-10-04 7:22 ` Bartosz Golaszewski 2019-10-04 12:46 ` Bartosz Golaszewski 2019-10-05 17:02 ` Linus Walleij 2019-10-06 3:12 ` Kent Gibson 2019-10-06 21:06 ` Linus Walleij 2019-10-07 4:37 ` Kent Gibson 2019-10-08 6:15 ` Kent Gibson 2019-10-08 20:56 ` Bartosz Golaszewski 2019-10-08 23:21 ` Kent Gibson 2019-10-08 23:30 ` Bartosz Golaszewski 2019-10-08 23:56 ` Kent Gibson 2019-10-09 0:03 ` Bartosz Golaszewski 2019-10-09 0:22 ` Kent Gibson 2019-10-09 6:55 ` Kent Gibson 2019-10-09 12:57 ` Drew Fustini 2019-10-09 13:23 ` Kent Gibson [this message] 2019-10-09 13:30 ` Drew Fustini 2019-10-09 14:11 ` Kent Gibson 2019-10-09 15:50 ` Bartosz Golaszewski 2019-10-09 16:19 ` Kent Gibson 2019-10-09 23:59 ` Kent Gibson 2019-10-10 7:47 ` Drew Fustini 2019-10-10 10:14 ` Kent Gibson 2019-10-10 11:17 ` Kent Gibson 2019-10-11 13:04 ` Drew Fustini 2019-10-11 13:06 ` Drew Fustini 2019-10-11 13:49 ` Kent Gibson 2019-10-09 11:32 ` Drew Fustini 2019-10-09 13:57 ` Drew Fustini 2019-10-09 14:01 ` Kent Gibson 2019-10-09 11:46 ` Drew Fustini
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191009132346.GA1384@firefly \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-GPIO Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \ email@example.com public-inbox-index linux-gpio Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio AGPL code for this site: git clone https://public-inbox.org/public-inbox.git