From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8558C43215 for ; Mon, 18 Nov 2019 16:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0B21218AF for ; Mon, 18 Nov 2019 16:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574094036; bh=6Z3UN5A3BW1jsMv3ltooKPY0iW5X0XuSmfVz/7SFggM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wyLAtSqMa1YPmebQmUD72ZeBXG12gspVFtq1bhDrZAZj+DHHdhST4Y1yOUPTwhWw9 2Ru2xmI/tCYDQSyRU6T2teavM5e3SjjK2icro6O5mkdGhzLb+NmBZ/oVEhHDhzsLac bkf3ZcOkFMunaZ4EYDvr+IydHlYUfOHZ1ESYmc0M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbfKRQUg (ORCPT ); Mon, 18 Nov 2019 11:20:36 -0500 Received: from foss.arm.com ([217.140.110.172]:36694 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbfKRQUf (ORCPT ); Mon, 18 Nov 2019 11:20:35 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC2861FB; Mon, 18 Nov 2019 08:20:34 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2ADEB3F703; Mon, 18 Nov 2019 08:20:34 -0800 (PST) Date: Mon, 18 Nov 2019 16:20:32 +0000 From: Mark Brown To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Lee Jones , Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Mark Rutland , Liam Girdwood , Jonathan Corbet , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , Mauro Carvalho Chehab , Jeff Kirsher , Wolfram Sang , Marek Szyprowski , Heiner Kallweit , Nicholas Mc Guire , Phil Edworthy , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v5 09/16] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Message-ID: <20191118162032.GI9761@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BWWlCdgt6QLN7tv3" Content-Disposition: inline In-Reply-To: X-Cookie: no maintenance: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --BWWlCdgt6QLN7tv3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 18, 2019 at 08:57:57AM +0200, Matti Vaittinen wrote: > +static int ramp_delay_supported(struct regulator_dev *rdev) > +{ > + switch (rdev->desc->id) { > + case BD71828_BUCK1: > + case BD71828_BUCK2: > + case BD71828_BUCK6: > + case BD71828_BUCK7: > + return 1; > + default: > + break; > + } > + return 0; > +} > + > +static int bd71828_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) > +{ > + unsigned int val; > + > + if (!ramp_delay_supported(rdev)) { > + dev_err(&rdev->dev, "%s: can't set ramp-delay\n", > + rdev->desc->name); > + return -EINVAL; Rather than doing this it's better to just not provide the operation for devices that don't support it, that makes the handling in the core easier. --BWWlCdgt6QLN7tv3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3SxM8ACgkQJNaLcl1U h9Aq0QgAgjb3+2lEoadTP4w8qi9OfeekF/Te3BOzBoRw/N3CEI0LRdBuZ0f+Co++ QefQkzBXUOq8Pu7bNj+3h6eZiOVqwzPGej79fhswkmFiZGzPNHGJEegNAIQQm0Gt FxLz5qVqIfx2orOMrYbVMIYffkH3hHE5twc3PoUf6lTpyUoErQ1miskrOfiKdqe3 WBlMS73mAzeN65q87QNESqie94xl+DxAY0caeTePuvbEA06Hgf6ZgHvv0uxb/38q 7lI/AzRptAy7HJqHYy6onIRxd12cBoKYa8SsoOlghgepja3prAwDE0eQ0iXo260q kJTWfpuB6S3o/I5A6W0SUuKwiktIEw== =/GhS -----END PGP SIGNATURE----- --BWWlCdgt6QLN7tv3--