From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 326D0C432C0 for ; Fri, 22 Nov 2019 06:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDF2C2068E for ; Fri, 22 Nov 2019 06:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574403165; bh=BlxeznEm3n30PyFcV4J0Ki0w3dhhBWFP5ESTOP+yQTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OLZgKCPj41yE/W4XXJFNeemAChrMy+pfIDAbC2xXeeGd6y6HlYqtU2hdO+7zZIIqq xEMxu5tJyARJuLx9xUPpyMym74PM/SgyhVB7B7+gWERTE+ENY/2vvaYWyvr2Aa5m8j KgzKRIKt/HPOJU5lx77r7bN3NNb+ZMpvqipRggfA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729055AbfKVF4P (ORCPT ); Fri, 22 Nov 2019 00:56:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:34006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728722AbfKVF4O (ORCPT ); Fri, 22 Nov 2019 00:56:14 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5651C20717; Fri, 22 Nov 2019 05:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574402174; bh=BlxeznEm3n30PyFcV4J0Ki0w3dhhBWFP5ESTOP+yQTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HRzJ52l3RTXdlktg7v9z9XLxvt7dXGQLYe+VsWLjd9/ytR6bZMfLrD82cdz7FYVjz l4w/9aAENclwuB63lEripklUT8mHs/z96/nt3jEHPs22Y72I/15/vXPVEZYzVyfKxu blz8opwQZMQu3YKH/4zHRMRAUj+MOadtcNrUPVvQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Krzysztof Kozlowski , Linus Walleij , Sasha Levin , linux-gpio@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 026/127] gpiolib: Fix return value of gpio_to_desc() stub if !GPIOLIB Date: Fri, 22 Nov 2019 00:54:04 -0500 Message-Id: <20191122055544.3299-25-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122055544.3299-1-sashal@kernel.org> References: <20191122055544.3299-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit c5510b8dafce5f3f5a039c9b262ebcae0092c462 ] If CONFIG_GPOILIB is not set, the stub of gpio_to_desc() should return the same type of error as regular version: NULL. All the callers compare the return value of gpio_to_desc() against NULL, so returned ERR_PTR would be treated as non-error case leading to dereferencing of error value. Fixes: 79a9becda894 ("gpiolib: export descriptor-based GPIO interface") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- include/linux/gpio/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index c4a350d835788..79ad4f8b889dc 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -404,7 +404,7 @@ static inline int gpiod_to_irq(const struct gpio_desc *desc) static inline struct gpio_desc *gpio_to_desc(unsigned gpio) { - return ERR_PTR(-EINVAL); + return NULL; } static inline int desc_to_gpio(const struct gpio_desc *desc) -- 2.20.1