Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Peng Fan <peng.fan@nxp.com>,
	"rjui@broadcom.com" <rjui@broadcom.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"sbranden@broadcom.com" <sbranden@broadcom.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com" 
	<bcm-kernel-feedback-list@broadcom.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alice Guo <alice.guo@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v2 1/2] gpio: mvebu: use platform_irq_count
Date: Wed, 4 Dec 2019 19:47:54 +0100
Message-ID: <20191204184754.5oj2xoem2v3544rx@pengutronix.de> (raw)
In-Reply-To: <CAMpxmJUAk5Y3mX_irTjwveaii8W=coaG0w2aWvFXUEXqHxpArQ@mail.gmail.com>

On Wed, Dec 04, 2019 at 05:33:04PM +0100, Bartosz Golaszewski wrote:
> śr., 4 gru 2019 o 08:24 Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> napisał(a):
> >
> > On Wed, Dec 04, 2019 at 04:20:41AM +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > platform_irq_count() is the more generic way (independent of
> > > device trees) to determine the count of available interrupts. So
> > > use this instead.
> > >
> > > As platform_irq_count() might return an error code (which
> > > of_irq_count doesn't) some additional handling is necessary.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Reviewed-and-Commit-Log-Provided-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> This is not a valid tag, but I take it as Suggested-by and Reviewed-by. :)

If you care about the validity of such tags, I suggest you take a look
at the output of

	$ git rev-list v4.0..v5.4 | while read rev; do git cat-file commit $rev; done | sed -n 's/ *\(.*-by\):.*/\1/p' | sort | uniq -c | sort -n

(which finds all tags used between 4.0 and 5.4 with its usage count).

A few of the tags (admittedly with low usage count :-) included there are:

  Badly-reviewed-by
  Bonus-points-awarded-by
  Compile-tested and Reviewed-by
  Enthusiastically-Acked-by
  Mea-culpa-by
  \o/-by
  Brown-paper-bag-by

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  4:20 Peng Fan
2019-12-04  4:20 ` [PATCH v2 2/2] gpio: bcm-kona: " Peng Fan
2019-12-04  7:27   ` Uwe Kleine-König
2019-12-04  8:41     ` Peng Fan
2019-12-04  9:17       ` Uwe Kleine-König
2019-12-04  7:24 ` [PATCH v2 1/2] gpio: mvebu: " Uwe Kleine-König
2019-12-04 16:33   ` Bartosz Golaszewski
2019-12-04 18:47     ` Uwe Kleine-König [this message]
2019-12-05  9:22       ` Bartosz Golaszewski

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204184754.5oj2xoem2v3544rx@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=alice.guo@nxp.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git