Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 1/2] gpio: mvebu: use platform_irq_count
@ 2019-12-04  4:20 Peng Fan
  2019-12-04  4:20 ` [PATCH v2 2/2] gpio: bcm-kona: " Peng Fan
  2019-12-04  7:24 ` [PATCH v2 1/2] gpio: mvebu: " Uwe Kleine-König
  0 siblings, 2 replies; 9+ messages in thread
From: Peng Fan @ 2019-12-04  4:20 UTC (permalink / raw)
  To: rjui, linus.walleij, bgolaszewski, f.fainelli, sbranden,
	thierry.reding, robh
  Cc: bcm-kernel-feedback-list, u.kleine-koenig, dl-linux-imx,
	linux-gpio, linux-pwm, linux-kernel, Alice Guo, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

platform_irq_count() is the more generic way (independent of
device trees) to determine the count of available interrupts. So
use this instead.

As platform_irq_count() might return an error code (which
of_irq_count doesn't) some additional handling is necessary.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Update commit log, add err handling
 Not tested, just code inspection

 drivers/gpio/gpio-mvebu.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index 993bbeb3c006..f0fd82b3417c 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -46,7 +46,6 @@
 #include <linux/irqdomain.h>
 #include <linux/mfd/syscon.h>
 #include <linux/of_device.h>
-#include <linux/of_irq.h>
 #include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
 #include <linux/pwm.h>
@@ -1102,7 +1101,11 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
 		soc_variant = MVEBU_GPIO_SOC_VARIANT_ORION;
 
 	/* Some gpio controllers do not provide irq support */
-	have_irqs = of_irq_count(np) != 0;
+	err = platform_irq_count(pdev);
+	if (err < 0)
+		return err;
+
+	have_irqs = err != 0;
 
 	mvchip = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_gpio_chip),
 			      GFP_KERNEL);
-- 
2.16.4


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04  4:20 [PATCH v2 1/2] gpio: mvebu: use platform_irq_count Peng Fan
2019-12-04  4:20 ` [PATCH v2 2/2] gpio: bcm-kona: " Peng Fan
2019-12-04  7:27   ` Uwe Kleine-König
2019-12-04  8:41     ` Peng Fan
2019-12-04  9:17       ` Uwe Kleine-König
2019-12-04  7:24 ` [PATCH v2 1/2] gpio: mvebu: " Uwe Kleine-König
2019-12-04 16:33   ` Bartosz Golaszewski
2019-12-04 18:47     ` Uwe Kleine-König
2019-12-05  9:22       ` Bartosz Golaszewski

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git