From: Mark Brown <broonie@kernel.org> To: Marco Felsch <m.felsch@pengutronix.de> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Support Opensource <Support.Opensource@diasemi.com>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "andrew@aj.id.au" <andrew@aj.id.au>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "joel@jms.id.au" <joel@jms.id.au>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Adam Thomson <Adam.Thomson.Opensource@diasemi.com>, "lee.jones@linaro.org" <lee.jones@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation Date: Mon, 16 Dec 2019 11:44:54 +0000 Message-ID: <20191216114454.GB4161@sirena.org.uk> (raw) In-Reply-To: <20191216085525.csr2aglm5md4vtsw@pengutronix.de> [-- Attachment #1: Type: text/plain, Size: 782 bytes --] On Mon, Dec 16, 2019 at 09:55:25AM +0100, Marco Felsch wrote: > On 19-12-12 16:51, Mark Brown wrote: > > Something needs to say what that thing is, especially if it's runtime > > controllable. In your case from the point of view of software there is > > actually no enable control so we shouldn't be providing an enable > > operation to the framework. > The enabel control signal is always available, please check [1] table > 63. There is a mux in front of the enable pin so: What I'm saying is that I think the binding needs to explicitly talk about that since at the minute it's really confusing reading it as it is, it sounds very much like it's trying to override that in a chip specific fashion as using gpiolib and the GPIO bindings for pinmuxing is really quite unusual. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply index Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-29 17:25 [PATCH v3 0/6] DA9062 PMIC features Marco Felsch 2019-11-29 17:25 ` [PATCH v3 1/6] gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset Marco Felsch 2019-12-02 2:59 ` Andrew Jeffery 2019-11-29 17:25 ` [PATCH v3 2/6] gpio: make gpiod_to_offset() available for other users Marco Felsch 2019-12-02 3:00 ` Andrew Jeffery 2019-11-29 17:25 ` [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation Marco Felsch 2019-12-04 13:46 ` Mark Brown 2019-12-10 9:41 ` Marco Felsch 2019-12-11 16:14 ` Adam Thomson 2019-12-11 17:09 ` Marco Felsch 2019-12-12 15:08 ` Linus Walleij 2019-12-12 15:55 ` Marco Felsch 2019-12-12 16:10 ` Mark Brown 2019-12-12 16:21 ` Marco Felsch 2019-12-12 16:51 ` Mark Brown 2019-12-16 8:55 ` Marco Felsch 2019-12-16 11:44 ` Mark Brown [this message] 2019-12-17 7:35 ` Marco Felsch 2019-12-17 12:58 ` Mark Brown 2020-01-07 8:36 ` Marco Felsch 2020-01-07 13:09 ` Mark Brown 2020-01-07 13:38 ` Marco Felsch 2020-01-14 15:43 ` Mark Brown 2019-12-16 16:32 ` Adam Thomson 2019-12-17 9:00 ` Marco Felsch 2019-12-17 9:12 ` Marco Felsch 2019-12-17 9:53 ` Adam Thomson 2019-12-17 12:31 ` Marco Felsch 2019-12-17 13:13 ` Adam Thomson 2019-12-16 16:32 ` Adam Thomson 2019-12-16 12:28 ` Linus Walleij 2019-11-29 17:25 ` [PATCH v3 4/6] regulator: da9062: add voltage selection gpio support Marco Felsch 2019-11-29 17:25 ` [PATCH v3 5/6] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation Marco Felsch 2019-12-13 22:23 ` Rob Herring 2019-12-16 16:31 ` Lee Jones 2019-11-29 17:25 ` [PATCH v3 6/6] regulator: da9062: add gpio based regulator dis-/enable support Marco Felsch 2019-12-02 11:44 ` [PATCH v3 0/6] DA9062 PMIC features Linus Walleij 2019-12-02 12:04 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191216114454.GB4161@sirena.org.uk \ --to=broonie@kernel.org \ --cc=Adam.Thomson.Opensource@diasemi.com \ --cc=Support.Opensource@diasemi.com \ --cc=andrew@aj.id.au \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=m.felsch@pengutronix.de \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-GPIO Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \ linux-gpio@vger.kernel.org public-inbox-index linux-gpio Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio AGPL code for this site: git clone https://public-inbox.org/public-inbox.git