From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Marek Vasut <marek.vasut@gmail.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [PATCH v1 2/2] [RFC] gpio: pca953x: drop unused parameters of pca953x_recalc_addr()
Date: Mon, 30 Mar 2020 17:07:46 +0300 [thread overview]
Message-ID: <20200330140746.GR1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200328194123.GB1922688@smile.fi.intel.com>
On Sat, Mar 28, 2020 at 09:41:23PM +0200, Andy Shevchenko wrote:
> On Sat, Mar 28, 2020 at 10:27:30AM +0100, Uwe Kleine-König wrote:
> > On Fri, Mar 27, 2020 at 11:06:43PM +0100, H. Nikolaus Schaller wrote:
>
> > I'm still waiting for more feedback and then will send out a v2.
>
> From code perspective looks good,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> If you give me some time (couple of days) I'll test it on PCA9555 (for no
> regression).
No regression found in my case (PCA9555 + IRQ test)
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-03-30 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 7:49 register access issues in pca953x gpio driver Uwe Kleine-König
2020-03-27 10:26 ` Andy Shevchenko
2020-03-27 13:49 ` Uwe Kleine-König
2020-03-27 13:03 ` Mark Brown
2020-03-27 13:46 ` Uwe Kleine-König
2020-03-27 13:58 ` Mark Brown
2020-03-27 17:22 ` [PATCH v1 0/2] gpio: pca953x: fix handling of automatic address incrementing Uwe Kleine-König
2020-03-27 17:22 ` [PATCH v1 1/2] [RFC] " Uwe Kleine-König
2020-03-27 17:22 ` [PATCH v1 2/2] [RFC] gpio: pca953x: drop unused parameters of pca953x_recalc_addr() Uwe Kleine-König
2020-03-27 22:06 ` H. Nikolaus Schaller
2020-03-28 9:27 ` Uwe Kleine-König
2020-03-28 19:41 ` Andy Shevchenko
2020-03-30 14:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330140746.GR1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pengutronix.de \
--cc=letux-kernel@openphoenux.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).