From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B5CBC352BE for ; Thu, 16 Apr 2020 14:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C8C221D7E for ; Thu, 16 Apr 2020 14:41:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="w3aiss/S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394453AbgDPOlg (ORCPT ); Thu, 16 Apr 2020 10:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2394448AbgDPOl0 (ORCPT ); Thu, 16 Apr 2020 10:41:26 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E945CC061A0C; Thu, 16 Apr 2020 07:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tLjN/nPsRscBzXHkmgVPun+eK2xtxPpGYdMPS7Z6B9M=; b=w3aiss/S89mWYK6GKHriGLOdo UCj3P6LDJQougYx1COFdPAWZEQvQmq0cr7MskscE1hM0hr5uapWgBpJES4Vifk5UYcdMG9YyUPuG9 JsW9KRlADfJ4jf6mwxtZ800Ci4EvuxDN2+mEHP/yQowVsDlyKOey3EOLmEEP065Czz2/9Gmz+sV4O fsKJuBbMrvuFP7/Jxb7OEtcfC0tBAImx/lNEhRxJxRWAom00aNfauVHDDsqla7UiMyFpJPNC/MJy0 Gx1+41HDFbRWen5KQvD95/lCJSLD4eStn4EgfxIOP6qB+d+wtzX11rPi52HR4XyAt43xQ4krZ5GR7 6UmMu9w7w==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:46746) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jP5hc-0004hW-KW; Thu, 16 Apr 2020 15:41:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jP5ha-0001y9-6X; Thu, 16 Apr 2020 15:41:14 +0100 Date: Thu, 16 Apr 2020 15:41:14 +0100 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Linus Walleij , Bartosz Golaszewski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Gregory Clement , Jason Cooper , Linux ARM , "open list:GPIO SUBSYSTEM" , linux-pwm@vger.kernel.org, Mark Rutland , Rob Herring , Sebastian Hesselbarth , Thierry Reding , Uwe Kleine-Konig Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Message-ID: <20200416144114.GI25745@shell.armlinux.org.uk> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <20200416142944.GH25745@shell.armlinux.org.uk> <20200416143645.GN657811@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416143645.GN657811@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Apr 16, 2020 at 04:36:45PM +0200, Andrew Lunn wrote: > > I said in the cover message "The cooling maps are experimental". > > They work reasonably well for me with the fan I have (a noctua fan) > > but other people may find them to be problematical, so one of the > > reasons for sending it as RFC is to get people to test and see how > > well it works. > > Hi Russell > > Maybe split the PWM parts from the cooling maps? I don't see any > reason not to merge the PWM parts. That's easy - the cooling maps are an entirely separate patch. However, one thing we need to be careful of is whether someone has a PWM fan plugged in, and whether not having any cooling maps results in the fan stopping, as I think PWMs default to being disabled on initialisation. That could be a SoC-killing combination. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up