From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Lars Povlsen <lars.povlsen@microchip.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH] pinctrl: ocelot: Add platform dependency
Date: Thu, 7 May 2020 14:44:19 +0200 [thread overview]
Message-ID: <20200507124419.GG34497@piout.net> (raw)
In-Reply-To: <87ftccorqd.fsf@soft-dev15.microsemi.net>
On 07/05/2020 14:27:06+0200, Lars Povlsen wrote:
>
> Alexandre Belloni writes:
>
> > Hi,
> >
> > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote:
> >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot
> >> and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT
> >> config symbol, to avoid asking the user about it when configuring a
> >> kernel without Ocelot or Jaguar2 support.
> >>
> >
> > I have to NAK here because there are upcoming (hopefully this cycle)
> > SoCs using this driver.
> >
>
> Not only because of that, but also an arbitrary system connecting to
> ocelot by PCI could be using the driver.
>
Right, and that was why I removed the dependency when adding jaguar2
support I never booted the mips core of jaguar2, I used it using PCIe.
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> ---
> >> drivers/pinctrl/Kconfig | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> >> index f0ce4ce3e0f52456..bed67c08a0892240 100644
> >> --- a/drivers/pinctrl/Kconfig
> >> +++ b/drivers/pinctrl/Kconfig
> >> @@ -394,8 +394,8 @@ config PINCTRL_RK805
> >>
> >> config PINCTRL_OCELOT
> >> bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs"
> >> - depends on OF
> >> - depends on HAS_IOMEM
> >> + depends on OF && HAS_IOMEM
> >> + depends on MSCC_OCELOT || COMPILE_TEST
> >> select GPIOLIB
> >> select GPIOLIB_IRQCHIP
> >> select GENERIC_PINCONF
> >> --
> >> 2.17.1
> >>
>
> --
> Lars Povlsen,
> Microchip
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-05-07 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 11:40 [PATCH] pinctrl: ocelot: Add platform dependency Geert Uytterhoeven
2020-05-07 11:45 ` Alexandre Belloni
2020-05-07 11:52 ` Geert Uytterhoeven
2020-05-07 12:27 ` Lars Povlsen
2020-05-07 12:44 ` Alexandre Belloni [this message]
2020-05-11 11:39 ` Geert Uytterhoeven
2020-05-11 14:20 ` Alexandre Belloni
2020-05-11 14:48 ` Geert Uytterhoeven
2020-05-11 14:53 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507124419.GG34497@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).