linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: Rob Herring <robh@kernel.org>
Cc: "Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Hyun Kwon" <hyunk@xilinx.com>,
	linux-media@vger.kernel.org,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
	sakari.ailus@iki.fi,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	devicetree@vger.kernel.org,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	linux-renesas-soc@vger.kernel.org,
	"Rob Herring" <robh+dt@kernel.org>,
	"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
	"Hans Verkuil" <hverkuil@xs4all.nl>
Subject: Re: [PATCH v10 1/4] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286
Date: Sat, 13 Jun 2020 14:32:07 +0200	[thread overview]
Message-ID: <20200613123207.6ey6y5spfa5ajk4h@uno.localdomain> (raw)
In-Reply-To: <20200612221003.GA3901624@bogus>

Hi Rob,

On Fri, Jun 12, 2020 at 04:10:03PM -0600, Rob Herring wrote:
> On Fri, 12 Jun 2020 15:47:10 +0100, Kieran Bingham wrote:
> > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >
> > The MAX9286 deserializes video data received on up to 4 Gigabit
> > Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up
> > to 4 data lanes.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > ---
> >
> > v7:
> >  - Collect Rob's RB tag
> >  - Remove redundant maxItems from remote-endpoints
> >  - Fix SPDX licence tag
> >
> > v10:
> > [Jacopo]
> >  - Fix dt-validation
> >  - Fix dt-binding examples with 2 reg entries
> >
> > [Kieran]
> >  - Correctly match the hex camera node reg
> >  - Add (required) GPIO controller support
> >
> >  .../bindings/media/i2c/maxim,max9286.yaml     | 366 ++++++++++++++++++
> >  1 file changed, 366 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dt.yaml: example-0: i2c@e66d8000:reg:0: [0, 3865935872, 0, 64] is too long
>
>
> See https://patchwork.ozlabs.org/patch/1308280
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>

I have updated my dt-schema installation to the latest github master
-------------------------------------------------------------------------------
Successfully installed dtschema-2020.6.dev8+g4d2d86c

https://github.com/devicetree-org/dt-schema/commit/4d2d86c5cd65cd3944ce0aaa400866bc36727bea

$ /usr/bin/dt-validate -V
2020.6.dev8+g4d2d86c
-------------------------------------------------------------------------------

But I still cannot reproduce the error.

However, I see this commit in your next branch
https://github.com/devicetree-org/dt-schema/commit/b72500282cfd2eba6f9df4d7553f696544b40ee6
"schemas: Add a schema to check 'reg' sizes "

Which sounds very likely related to the above reported error.
Was this intentional ?

I'm not sure how I should handle this. The error reports the i2c node
parents should have both address-cells and size-cells properties set
to 2, but in the example there is not i2c node parent at all :)
Should I add a parent node for the i2c in the example snippet ?

Thanks
  j

> Please check and re-submit.
>

  reply	other threads:[~2020-06-13 12:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 14:47 [PATCH v10 0/4] MAX9286 GMSL Support (+RDACM20) Kieran Bingham
2020-06-12 14:47 ` [PATCH v10 1/4] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286 Kieran Bingham
2020-06-12 22:10   ` Rob Herring
2020-06-13 12:32     ` Jacopo Mondi [this message]
2020-06-15 15:02       ` Rob Herring
2020-06-15 15:19         ` Jacopo Mondi
2020-07-03 13:33   ` [PATCH v10.1] " Jacopo Mondi
2020-06-12 14:47 ` [PATCH v10 2/4] media: i2c: Add MAX9286 driver Kieran Bingham
2020-06-13  7:09   ` Manivannan Sadhasivam
2020-07-16  9:02   ` Kieran Bingham
2020-07-23 22:28     ` Sakari Ailus
2020-07-24  9:32       ` Kieran Bingham
2020-07-25  8:47         ` Sakari Ailus
2020-06-12 14:47 ` [PATCH v10 3/4] dt-bindings: media: i2c: Add bindings for IMI RDACM2x Kieran Bingham
2020-06-12 22:11   ` Rob Herring
2020-07-15  9:43   ` [PATCH v10.1 " Kieran Bingham
2020-06-12 14:47 ` [PATCH v10 4/4] media: i2c: Add RDACM20 driver Kieran Bingham
2020-07-16  9:07   ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200613123207.6ey6y5spfa5ajk4h@uno.localdomain \
    --to=jacopo@jmondi.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=hyunk@xilinx.com \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).