Re: [PATCH v1 4/4] gpio: pca953x: disable regmap locking for automatic address incrementing

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]

Hello,

[adding Geert to Cc as he was involved with
aa58a21ae37894d456a2f91a37e9fd71ad4aa27e]

On Mon, Jun 15, 2020 at 03:53:49PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 15, 2020 at 02:20:44PM +0200, Uwe Kleine-König wrote:
> > On Fri, Jun 05, 2020 at 04:40:36PM +0300, Andy Shevchenko wrote:
> > > It's a repetition of the commit aa58a21ae378
> > >   ("gpio: pca953x: disable regmap locking")
> > > which states the following:
> > > 
> > >   This driver uses its own locking but regmap silently uses
> > >   a mutex for all operations too. Add the option to disable
> > >   locking to the regmap config struct.
> > > 
> > > Fixes: bcf41dc480b1 ("gpio: pca953x: fix handling of automatic address incrementing")
> > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > Ah, good catch. I assume that I didn't have aa58a21ae378 in my tree when
> > I created the patch that then became bcf41dc480b1.
> > 
> > Looks right
> > 
> > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Thanks!
> 
> Linus, Bart, just to clarify that this is material for one of the next v5.8-rcX
> (this cycle!).

I didn't test but I wonder if this patch is really urgent. Just from
looking I'd say two locks are not nice but also don't hurt much. If it
is more urgent the commit log should maybe mention how the driver is
broken without this change? (Also applies to
aa58a21ae37894d456a2f91a37e9fd71ad4aa27e of course (but too late).)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]