From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 2/3] pinctrl: lynxpoint: Make use of for_each_requested_gpio()
Date: Mon, 15 Jun 2020 18:13:52 +0300 [thread overview]
Message-ID: <20200615151353.88194-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200615151353.88194-1-andriy.shevchenko@linux.intel.com>
Make use of for_each_requested_gpio() instead of home grown analogue.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-lynxpoint.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-lynxpoint.c b/drivers/pinctrl/intel/pinctrl-lynxpoint.c
index a45b8f2182fd..2a3af998b91c 100644
--- a/drivers/pinctrl/intel/pinctrl-lynxpoint.c
+++ b/drivers/pinctrl/intel/pinctrl-lynxpoint.c
@@ -919,16 +919,17 @@ static int lp_gpio_runtime_resume(struct device *dev)
static int lp_gpio_resume(struct device *dev)
{
struct intel_pinctrl *lg = dev_get_drvdata(dev);
+ struct gpio_chip *chip = &lg->chip;
+ const char *dummy;
void __iomem *reg;
int i;
/* on some hardware suspend clears input sensing, re-enable it here */
- for (i = 0; i < lg->chip.ngpio; i++) {
- if (gpiochip_is_requested(&lg->chip, i) != NULL) {
- reg = lp_gpio_reg(&lg->chip, i, LP_CONFIG2);
- iowrite32(ioread32(reg) & ~GPINDIS_BIT, reg);
- }
+ for_each_requested_gpio(chip, i, dummy) {
+ reg = lp_gpio_reg(chip, i, LP_CONFIG2);
+ iowrite32(ioread32(reg) & ~GPINDIS_BIT, reg);
}
+
return 0;
}
--
2.27.0.rc2
next prev parent reply other threads:[~2020-06-15 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 15:13 [PATCH v3 0/3] pinctrl: intel: Reuse for_each_requested_gpio*() macros Andy Shevchenko
2020-06-15 15:13 ` [PATCH v3 1/3] pinctrl: intel: Make use of for_each_requested_gpio_in_range() Andy Shevchenko
2020-06-16 1:16 ` kernel test robot
2020-06-16 5:36 ` Andy Shevchenko
2020-06-17 1:14 ` [kbuild-all] " Philip Li
2020-06-15 15:13 ` Andy Shevchenko [this message]
2020-06-16 3:42 ` [PATCH v3 2/3] pinctrl: lynxpoint: Make use of for_each_requested_gpio() kernel test robot
2020-06-15 15:13 ` [PATCH v3 3/3] pinctrl: lynxpoint: Introduce helpers to enable or disable input Andy Shevchenko
2020-06-15 16:33 ` [PATCH v3 0/3] pinctrl: intel: Reuse for_each_requested_gpio*() macros Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615151353.88194-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).