linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sungbo Eo <mans0n@gorani.run>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: kbuild-all@lists.01.org, Sungbo Eo <mans0n@gorani.run>
Subject: Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570
Date: Thu, 25 Jun 2020 22:43:30 +0800	[thread overview]
Message-ID: <202006252217.4lWTBJaP%lkp@intel.com> (raw)
In-Reply-To: <20200625075805.363918-1-mans0n@gorani.run>

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

Hi Sungbo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[also build test ERROR on v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sungbo-Eo/gpio-add-GPO-driver-for-PCA9570/20200625-160356
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpio/gpio-pca9570.c:141:12: error: 'pca9570_remove' undeclared here (not in a function); did you mean 'pca9570_probe'?
     141 |  .remove = pca9570_remove,
         |            ^~~~~~~~~~~~~~
         |            pca9570_probe

vim +141 drivers/gpio/gpio-pca9570.c

   134	
   135	static struct i2c_driver pca9570_driver = {
   136		.driver = {
   137			.name = "pca9570",
   138			.of_match_table = pca9570_of_match_table,
   139		},
   140		.probe = pca9570_probe,
 > 141		.remove = pca9570_remove,
   142		.id_table = pca9570_id_table,
   143	};
   144	module_i2c_driver(pca9570_driver);
   145	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67044 bytes --]

  parent reply	other threads:[~2020-06-25 14:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25  7:58 [PATCH v2 1/2] gpio: add GPO driver for PCA9570 Sungbo Eo
2020-06-25  8:59 ` Andy Shevchenko
2020-06-25 14:43 ` kernel test robot [this message]
2020-06-25 16:38 ` kernel test robot
2020-06-30  9:18 ` Bartosz Golaszewski
2020-06-30  9:53   ` Andy Shevchenko
2020-06-30 16:11     ` Sungbo Eo
2020-06-30 21:23       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006252217.4lWTBJaP%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mans0n@gorani.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).