* [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword
@ 2020-07-16 21:19 Gustavo A. R. Silva
2020-07-20 10:40 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-16 21:19 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko, Linus Walleij
Cc: linux-gpio, linux-kernel, Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index a917a2df520e..d6e35cba3065 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1372,13 +1372,13 @@ static void byt_irq_unmask(struct irq_data *d)
switch (irqd_get_trigger_type(d)) {
case IRQ_TYPE_LEVEL_HIGH:
value |= BYT_TRIG_LVL;
- /* fall through */
+ fallthrough;
case IRQ_TYPE_EDGE_RISING:
value |= BYT_TRIG_POS;
break;
case IRQ_TYPE_LEVEL_LOW:
value |= BYT_TRIG_LVL;
- /* fall through */
+ fallthrough;
case IRQ_TYPE_EDGE_FALLING:
value |= BYT_TRIG_NEG;
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword
2020-07-16 21:19 [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword Gustavo A. R. Silva
@ 2020-07-20 10:40 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2020-07-20 10:40 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij, linux-gpio,
linux-kernel, Gustavo A. R. Silva
On Thu, Jul 16, 2020 at 04:19:19PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Pushed to my review and testing queue, thanks!
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index a917a2df520e..d6e35cba3065 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -1372,13 +1372,13 @@ static void byt_irq_unmask(struct irq_data *d)
> switch (irqd_get_trigger_type(d)) {
> case IRQ_TYPE_LEVEL_HIGH:
> value |= BYT_TRIG_LVL;
> - /* fall through */
> + fallthrough;
> case IRQ_TYPE_EDGE_RISING:
> value |= BYT_TRIG_POS;
> break;
> case IRQ_TYPE_LEVEL_LOW:
> value |= BYT_TRIG_LVL;
> - /* fall through */
> + fallthrough;
> case IRQ_TYPE_EDGE_FALLING:
> value |= BYT_TRIG_NEG;
> break;
> --
> 2.27.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-20 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 21:19 [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-20 10:40 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).