Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] Remove MT6779 UART3 clock support
@ 2020-07-21  5:40 Hanks Chen
  2020-07-21  5:40 ` [PATCH 1/2] dt-bindings: clock: remove " Hanks Chen
  2020-07-21  5:40 ` [PATCH 2/2] clk: mediatek: " Hanks Chen
  0 siblings, 2 replies; 5+ messages in thread
From: Hanks Chen @ 2020-07-21  5:40 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Matthias Brugger, Rob Herring
  Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel,
	linux-mediatek, linux-kernel, wsd_upstream, Hanks Chen

remove the redundant clk interface of uart.
CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Hanks Chen (2):
  dt-bindings: clock: remove UART3 clock support
  clk: mediatek: remove UART3 clock support

 drivers/clk/mediatek/clk-mt6779.c      | 2 --
 include/dt-bindings/clock/mt6779-clk.h | 1 -
 2 files changed, 3 deletions(-)

-- 
2.18.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dt-bindings: clock: remove UART3 clock support
  2020-07-21  5:40 [PATCH 0/2] Remove MT6779 UART3 clock support Hanks Chen
@ 2020-07-21  5:40 ` Hanks Chen
  2020-07-21 22:10   ` Matthias Brugger
  2020-07-21  5:40 ` [PATCH 2/2] clk: mediatek: " Hanks Chen
  1 sibling, 1 reply; 5+ messages in thread
From: Hanks Chen @ 2020-07-21  5:40 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Matthias Brugger, Rob Herring
  Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel,
	linux-mediatek, linux-kernel, wsd_upstream, Hanks Chen

remove the redundant clk interface of uart.

Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")
Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
---
 include/dt-bindings/clock/mt6779-clk.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/mt6779-clk.h
index b083139afbd2..2b5f2354d7eb 100644
--- a/include/dt-bindings/clock/mt6779-clk.h
+++ b/include/dt-bindings/clock/mt6779-clk.h
@@ -229,7 +229,6 @@
 #define CLK_INFRA_UART0			21
 #define CLK_INFRA_UART1			22
 #define CLK_INFRA_UART2			23
-#define CLK_INFRA_UART3			24
 #define CLK_INFRA_GCE_26M		25
 #define CLK_INFRA_CQ_DMA_FPC		26
 #define CLK_INFRA_BTIF			27
-- 
2.18.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] clk: mediatek: remove UART3 clock support
  2020-07-21  5:40 [PATCH 0/2] Remove MT6779 UART3 clock support Hanks Chen
  2020-07-21  5:40 ` [PATCH 1/2] dt-bindings: clock: remove " Hanks Chen
@ 2020-07-21  5:40 ` Hanks Chen
  1 sibling, 0 replies; 5+ messages in thread
From: Hanks Chen @ 2020-07-21  5:40 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Matthias Brugger, Rob Herring
  Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel,
	linux-mediatek, linux-kernel, wsd_upstream, Hanks Chen

CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.

Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")
Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
---
 drivers/clk/mediatek/clk-mt6779.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c
index 9766cccf5844..75f2235486be 100644
--- a/drivers/clk/mediatek/clk-mt6779.c
+++ b/drivers/clk/mediatek/clk-mt6779.c
@@ -923,8 +923,6 @@ static const struct mtk_gate infra_clks[] = {
 		    "uart_sel", 23),
 	GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",
 		    "uart_sel", 24),
-	GATE_INFRA0(CLK_INFRA_UART3, "infra_uart3",
-		    "uart_sel", 25),
 	GATE_INFRA0(CLK_INFRA_GCE_26M, "infra_gce_26m",
 		    "axi_sel", 27),
 	GATE_INFRA0(CLK_INFRA_CQ_DMA_FPC, "infra_cqdma_fpc",
-- 
2.18.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: clock: remove UART3 clock support
  2020-07-21  5:40 ` [PATCH 1/2] dt-bindings: clock: remove " Hanks Chen
@ 2020-07-21 22:10   ` Matthias Brugger
  2020-07-22  3:09     ` Hanks Chen
  0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2020-07-21 22:10 UTC (permalink / raw)
  To: Hanks Chen, Michael Turquette, Stephen Boyd, Rob Herring
  Cc: YueHaibing, mtk01761, CC Hwang, linux-gpio, linux-arm-kernel,
	linux-mediatek, linux-kernel, wsd_upstream



On 21/07/2020 07:40, Hanks Chen wrote:
> remove the redundant clk interface of uart.
> 
> Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")

These are cosmetic changes. They don't fix any bug, so we won't need a Fixes tag 
here. Neither on 2/2.

Regards,
Matthias

> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> ---
>   include/dt-bindings/clock/mt6779-clk.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/mt6779-clk.h
> index b083139afbd2..2b5f2354d7eb 100644
> --- a/include/dt-bindings/clock/mt6779-clk.h
> +++ b/include/dt-bindings/clock/mt6779-clk.h
> @@ -229,7 +229,6 @@
>   #define CLK_INFRA_UART0			21
>   #define CLK_INFRA_UART1			22
>   #define CLK_INFRA_UART2			23
> -#define CLK_INFRA_UART3			24
>   #define CLK_INFRA_GCE_26M		25
>   #define CLK_INFRA_CQ_DMA_FPC		26
>   #define CLK_INFRA_BTIF			27
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: clock: remove UART3 clock support
  2020-07-21 22:10   ` Matthias Brugger
@ 2020-07-22  3:09     ` Hanks Chen
  0 siblings, 0 replies; 5+ messages in thread
From: Hanks Chen @ 2020-07-22  3:09 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: Michael Turquette, Stephen Boyd, Rob Herring, YueHaibing,
	mtk01761, CC Hwang, linux-gpio, linux-arm-kernel, linux-mediatek,
	linux-kernel, wsd_upstream

On Wed, 2020-07-22 at 00:10 +0200, Matthias Brugger wrote:
> 
> On 21/07/2020 07:40, Hanks Chen wrote:
> > remove the redundant clk interface of uart.
> > 
> > Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")
> 
> These are cosmetic changes. They don't fix any bug, so we won't need a Fixes tag 
> here. Neither on 2/2.
> 
> Regards,
> Matthias
> 
Got it, I'll remove it in next version.

Thanks!

Hanks

> > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> > ---
> >   include/dt-bindings/clock/mt6779-clk.h | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/mt6779-clk.h
> > index b083139afbd2..2b5f2354d7eb 100644
> > --- a/include/dt-bindings/clock/mt6779-clk.h
> > +++ b/include/dt-bindings/clock/mt6779-clk.h
> > @@ -229,7 +229,6 @@
> >   #define CLK_INFRA_UART0			21
> >   #define CLK_INFRA_UART1			22
> >   #define CLK_INFRA_UART2			23
> > -#define CLK_INFRA_UART3			24
> >   #define CLK_INFRA_GCE_26M		25
> >   #define CLK_INFRA_CQ_DMA_FPC		26
> >   #define CLK_INFRA_BTIF			27
> > 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21  5:40 [PATCH 0/2] Remove MT6779 UART3 clock support Hanks Chen
2020-07-21  5:40 ` [PATCH 1/2] dt-bindings: clock: remove " Hanks Chen
2020-07-21 22:10   ` Matthias Brugger
2020-07-22  3:09     ` Hanks Chen
2020-07-21  5:40 ` [PATCH 2/2] clk: mediatek: " Hanks Chen

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git