Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Hoan Tran <hoan@os.amperecomputing.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
	Rob Herring <robh+dt@kernel.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/10] gpio: dwapb: Add max GPIOs macro
Date: Thu, 30 Jul 2020 18:42:19 +0300
Message-ID: <20200730154219.GS3703480@smile.fi.intel.com> (raw)
In-Reply-To: <20200730152808.2955-5-Sergey.Semin@baikalelectronics.ru>

On Thu, Jul 30, 2020 at 06:28:01PM +0300, Serge Semin wrote:
> Add a new macro DWAPB_MAX_GPIOS which defines the maximum possible number
> of GPIO lines corresponding to the maximum DW APB GPIO controller port
> width. Use the new macro instead of number literal 32 where it's
> applicable.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/gpio/gpio-dwapb.c                | 8 ++++----
>  include/linux/platform_data/gpio-dwapb.h | 4 +++-
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 3081213247d8..f34001152850 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -162,7 +162,7 @@ static struct dwapb_gpio_port *dwapb_offs_to_port(struct dwapb_gpio *gpio, unsig
>  
>  	for (i = 0; i < gpio->nr_ports; i++) {
>  		port = &gpio->ports[i];
> -		if (port->idx == offs / 32)
> +		if (port->idx == offs / DWAPB_MAX_GPIOS)
>  			return port;
>  	}
>  
> @@ -182,7 +182,7 @@ static void dwapb_toggle_trigger(struct dwapb_gpio *gpio, unsigned int offs)
>  
>  	pol = dwapb_read(gpio, GPIO_INT_POLARITY);
>  	/* Just read the current value right out of the data register */
> -	val = gc->get(gc, offs % 32);
> +	val = gc->get(gc, offs % DWAPB_MAX_GPIOS);
>  	if (val)
>  		pol &= ~BIT(offs);
>  	else
> @@ -197,7 +197,7 @@ static u32 dwapb_do_irq(struct dwapb_gpio *gpio)
>  	irq_hw_number_t hwirq;
>  
>  	irq_status = dwapb_read(gpio, GPIO_INTSTATUS);
> -	for_each_set_bit(hwirq, &irq_status, 32) {
> +	for_each_set_bit(hwirq, &irq_status, DWAPB_MAX_GPIOS) {
>  		int gpio_irq = irq_find_mapping(gpio->domain, hwirq);
>  		u32 irq_type = irq_get_trigger_type(gpio_irq);
>  
> @@ -599,7 +599,7 @@ static struct dwapb_platform_data *dwapb_gpio_get_pdata(struct device *dev)
>  			dev_info(dev,
>  				 "failed to get number of gpios for port%d\n",
>  				 i);
> -			pp->ngpio = 32;
> +			pp->ngpio = DWAPB_MAX_GPIOS;
>  		}
>  
>  		pp->irq_shared	= false;
> diff --git a/include/linux/platform_data/gpio-dwapb.h b/include/linux/platform_data/gpio-dwapb.h
> index ff1be737bad6..0aa5c6720259 100644
> --- a/include/linux/platform_data/gpio-dwapb.h
> +++ b/include/linux/platform_data/gpio-dwapb.h
> @@ -6,12 +6,14 @@
>  #ifndef GPIO_DW_APB_H
>  #define GPIO_DW_APB_H
>  
> +#define DWAPB_MAX_GPIOS		32
> +
>  struct dwapb_port_property {
>  	struct fwnode_handle *fwnode;
>  	unsigned int	idx;
>  	unsigned int	ngpio;
>  	unsigned int	gpio_base;
> -	int		irq[32];
> +	int		irq[DWAPB_MAX_GPIOS];
>  	bool		irq_shared;
>  };
>  
> -- 
> 2.27.0
> 

-- 
With Best Regards,
Andy Shevchenko



  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 15:27 [PATCH v3 00/10] gpio: dwapb: Refactor GPIO resources initialization Serge Semin
2020-07-30 15:27 ` [PATCH v3 01/10] dt-bindings: gpio: dwapb: Add ngpios property support Serge Semin
2020-07-30 15:27 ` [PATCH v3 02/10] gpio: dwapb: Add ngpios DT-property support Serge Semin
2020-07-30 15:28 ` [PATCH v3 03/10] gpio: dwapb: Move MFD-specific IRQ handler Serge Semin
2020-07-30 15:28 ` [PATCH v3 04/10] gpio: dwapb: Add max GPIOs macro Serge Semin
2020-07-30 15:42   ` Andy Shevchenko [this message]
2020-07-30 15:28 ` [PATCH v3 05/10] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip Serge Semin
2020-07-30 15:45   ` Andy Shevchenko
2020-07-30 15:28 ` [PATCH v3 06/10] gpio: dwapb: Discard GPIO-to-IRQ mapping function Serge Semin
2020-07-30 15:28 ` [PATCH v3 07/10] gpio: dwapb: Discard ACPI GPIO-chip IRQs request Serge Semin
2020-07-30 15:28 ` [PATCH v3 08/10] gpio: dwapb: Get reset control by means of resource managed interface Serge Semin
2020-07-30 15:28 ` [PATCH v3 09/10] gpio: dwapb: Get clocks " Serge Semin
2020-07-30 15:28 ` [PATCH v3 10/10] gpio: dwapb: Use resource managed GPIO-chip add data method Serge Semin
2020-08-27  8:34 ` [PATCH v3 00/10] gpio: dwapb: Refactor GPIO resources initialization Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730154219.GS3703480@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=hoan@os.amperecomputing.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git