From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E16C433DF for ; Tue, 18 Aug 2020 12:35:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EDD02065D for ; Tue, 18 Aug 2020 12:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726611AbgHRMfC (ORCPT ); Tue, 18 Aug 2020 08:35:02 -0400 Received: from mga06.intel.com ([134.134.136.31]:63673 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbgHRMfB (ORCPT ); Tue, 18 Aug 2020 08:35:01 -0400 IronPort-SDR: xEeIvizAIbJfNPiUI8hd5THpmFkDRvgHEEnUVT1CVsAQGhwegQHs+4SRMQQWrZyyvuyOwcGmyT wRZMJWC5uctQ== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="216415261" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="216415261" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 05:35:01 -0700 IronPort-SDR: Pfbwpin781qfSETg7rugTnHPwsVD02mHR2G6PLoyzj8vPfQry6mnBk9+aFnlciXH8EgIhBIFCe IkuA+fz4++PQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="326716994" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 18 Aug 2020 05:35:00 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k80pP-009e61-7T; Tue, 18 Aug 2020 15:34:59 +0300 Date: Tue, 18 Aug 2020 15:34:59 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: linux-gpio@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v1 1/3] pinctrl: intel: Extract intel_pinctrl_get_soc_data() helper for wider use Message-ID: <20200818123459.GL1891694@smile.fi.intel.com> References: <20200729115708.38112-1-andriy.shevchenko@linux.intel.com> <20200803123318.GR1375436@lahna.fi.intel.com> <20200803135031.GI3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200803135031.GI3703480@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Aug 03, 2020 at 04:50:31PM +0300, Andy Shevchenko wrote: > On Mon, Aug 03, 2020 at 03:33:18PM +0300, Mika Westerberg wrote: > > On Wed, Jul 29, 2020 at 02:57:06PM +0300, Andy Shevchenko wrote: > > > intel_pinctrl_get_soc_data() helper can be used in few driver instead of > > > open-coded variants. Thus, extract it as a standalone API. > > ... > > > > +const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct platform_device *pdev) > > > > Can we make this take const parameter as well? > > You mean > > const struct intel_pinctrl_soc_data * > intel_pinctrl_get_soc_data(const struct platform_device *pdev) > > ? > > Sure, I can do it for v2. Actually I can't. device_match_data() requires struct device * pointer and compiler is unable to compile with const qualifier. Are you good with current version then? -- With Best Regards, Andy Shevchenko